configure correctly tests dtrace -G in version 1.11 #351

Closed
wants to merge 1 commit into
from

Conversation

1 participant

sax commented Jul 6, 2013

dtrace version SUN D 1.11 introduces a check in the dtrace compiler to ensure that probes actually exist. If there are no probes, then dtrace -G step will fail.

Without this fix, on operating systems with the newer version of dtrace (for instance SmartOS platform images newer than June 2013) the configure step fails with the following error:
dtrace: failed to link script conftest_provider: No probe sites found for declared provider

This makes configure incorrectly determine that -G is not needed, and make subsequently fails.

As this test is only being used to determine whether -G is necessary (for instance, on OSX it is not), adding a real probe to the conftest allows it to succeed.

@sax sax configure correctly tests dtrace -G in version 1.11
dtrace version SUN D 1.11 introduces a check in the dtrace
compiler to ensure that probes actually exist. If there
are no probes, then the -G step will fail. As this test
is only being used to determine whether -G is necessary
(for instance, on OSX it is not), adding a real probe to
the conftest allows it to succeed on newer versions of dtrace.
d8c5fca

sax commented Jul 8, 2013

This is closed with this commit:
2b5f033

Thank you!

sax closed this Jul 8, 2013

@vipulnsward vipulnsward pushed a commit to vipulnsward/ruby that referenced this pull request Jul 10, 2013

@nobu nobu configure.in: correctly tests dtrace -G in version 1.11
* configure.in (RUBY_DTRACE_POSTPROCESS): dtrace version SUN D 1.11
  introduces a check in the dtrace compiler to ensure that probes
  actually exist. If there are no probes, then the -G step will
  fail. As this test is only being used to determine whether -G is
  necessary (for instance, on OSX it is not), adding a real probe to
  the conftest allows it to succeed on newer versions of dtrace.
  Patch by Eric Saxby <sax AT livinginthepast.org> at
  [ruby-core:55826].  [Fix GH-351], [Bug #8606].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@41815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2b5f033

@evanphx evanphx pushed a commit that referenced this pull request Jul 13, 2013

@nagachika nagachika merge revision(s) 41815,41816: [Backport #8606]
	* configure.in (RUBY_DTRACE_POSTPROCESS): dtrace version SUN D 1.11
	  introduces a check in the dtrace compiler to ensure that probes
	  actually exist. If there are no probes, then the -G step will
	  fail. As this test is only being used to determine whether -G is
	  necessary (for instance, on OSX it is not), adding a real probe to
	  the conftest allows it to succeed on newer versions of dtrace.
	  Patch by Eric Saxby <sax AT livinginthepast.org> at
	  [ruby-core:55826].  [Fix GH-351], [Bug #8606].


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@41943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
e62660c

@tenderlove tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014

@nobu nobu configure.in: correctly tests dtrace -G in version 1.11
* configure.in (RUBY_DTRACE_POSTPROCESS): dtrace version SUN D 1.11
  introduces a check in the dtrace compiler to ensure that probes
  actually exist. If there are no probes, then the -G step will
  fail. As this test is only being used to determine whether -G is
  necessary (for instance, on OSX it is not), adding a real probe to
  the conftest allows it to succeed on newer versions of dtrace.
  Patch by Eric Saxby <sax AT livinginthepast.org> at
  [ruby-core:55826].  [Fix GH-351], [Bug #8606].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@41815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
b6f67ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment