Fixes formatting in golf_prelude.rb #425

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

edward commented Oct 18, 2013

No description provided.

edward commented Oct 18, 2013

@zzak I was reading through some ruby source and saw this and decided I might as well fix up some formatting while looking at it.

Is there a test for this anywhere? There’s a mention in README.EXT but that’s about it.

The closest docs I could find for this are here: http://rbjl.net/34-do-you-know-the-official-ruby-interpreter-goruby

Member
zzak commented Oct 23, 2013

I have to regretfully reject this change.

The purpose of golf isn't to be the most well styled code, only as a joke. That said, consistency or style changes to it aren't very helpful.. consider it altering Mona Lisa (im sure some of the shading technique could be updated with today's technology right?)

I appreciate your contribution, and I'm sure many other committers feel the same as I do! If you find a bug in goruby, then we can think about an update 😁

Without objection I will close this ticket in a few days.

Thank you!

edward commented Oct 23, 2013

Consider this less an alteration to the Mona Lisa, and more like I saw some dings in the frame while I was walking by and decided to repair them to keep things professional.

Edward

On Oct 22, 2013, at 11:01 PM, Zachary Scott notifications@github.com wrote:

I have to regretfully reject this change.

The purpose of golf isn't to be the most well styled code, only as a joke. That said, consistency or style changes to it aren't very helpful.. consider it altering Mona Lisa (im sure some of the shading technique could be updated with today's technology right?)

I appreciate your contribution, and I'm sure many other committers feel the same as I do! If you find a bug in goruby, then we can think about an update

Without objection I will close this ticket in a few days.

Thank you!


Reply to this email directly or view it on GitHub.

Member
zzak commented Oct 23, 2013

@edward The thing is I think goruby is meant to be somewhat obfuscated?

edward commented Oct 23, 2013

@zzak I didn’t get that impression from looking at the code; there are some places where it’s been properly indented, and some others where it just looks sloppy and not purposefully obfuscated.

Member
zzak commented Oct 23, 2013

@edward by looking at the history of golf_prelude.rb, i've concluded that it's meant for golfers, not as golf.. with that in mind I'm considering this patch. Still, I would prefer another committers opinion in the matter before making any decision.

edward commented Oct 23, 2013

Sounds good. Thanks for your open mind.

Edward

On Oct 23, 2013, at 12:20 PM, Zachary Scott notifications@github.com wrote:

@edward by looking at the history of golf_prelude.rb, i've concluded that it's meant for golfers, not as golf.. with that in mind I'm considering this patch. Still, I would prefer another committers opinion in the matter before making any decision.


Reply to this email directly or view it on GitHub.

Member

@zzak: I'd say to go ahead and commit it.

Now I'm eagerly awaiting a pull request changing all hard tabs in*.c files to 8 spaces ;-)

edward commented Oct 23, 2013

@marcandre Oh man, the emacs is fierce. I just wish I had had a heads up somewhere in a Contributing section in the Ruby README about this preference. It had been driving me nuts as to what was going on until it finally dawned upon me that some editors do the mixed spaces/tabs thing.

@zzak zzak closed this in b393aeb Nov 7, 2013
@mmasaki mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Nov 8, 2013
@zzak zzak * golf_prelude.rb: syntax formatting for whitespace [Fixes GH-425]
  Patch by @edward ruby#425


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
7220024
@tenderlove tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
@zzak zzak * golf_prelude.rb: syntax formatting for whitespace [Fixes GH-425]
  Patch by @edward ruby#425


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
269f5e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment