Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduler hook Addrinfo.getaddrinfo. #4375

Merged
merged 2 commits into from Jun 14, 2021

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 9, 2021

This hook allows the fiber scheduler to implement asynchronous DNS lookup.

https://bugs.ruby-lang.org/issues/17370

@ioquatix ioquatix marked this pull request as draft April 9, 2021 21:33
@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch 2 times, most recently from 77ba38a to b3abaf1 Compare April 12, 2021 16:37
ext/socket/raddrinfo.c Outdated Show resolved Hide resolved
@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch from c3b12d4 to 36a7e2f Compare April 12, 2021 22:41
@ioquatix
Copy link
Member Author

Sorry, I was planning to review this the past weekend but ran out of time. Will defer to the coming weekend.

@ioquatix ioquatix force-pushed the fiber-scheduler-address_resolve branch from 36a7e2f to e23ea6b Compare April 23, 2021 23:02
@ioquatix
Copy link
Member Author

Rebased on master.

@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch from e23ea6b to 15df528 Compare April 27, 2021 16:30
@bruno-
Copy link
Contributor

bruno- commented Apr 27, 2021

I worked on changes we talked on slack:

As for the PR, would it be helpful to get on a zoom and do a "guided review" and explain the context?

@ioquatix
Copy link
Member Author

I will review this, this weekend.

ext/socket/raddrinfo.c Outdated Show resolved Hide resolved
@ioquatix
Copy link
Member Author

Rebased on master.

@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch from 3a878cb to 8e6635d Compare June 12, 2021 10:12
@ioquatix ioquatix self-assigned this Jun 12, 2021
@ioquatix ioquatix marked this pull request as ready for review June 12, 2021 10:14
@ioquatix
Copy link
Member Author

cc @kirs

@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch 2 times, most recently from 56e2a7e to 328bf81 Compare June 12, 2021 10:34
@kirs
Copy link
Contributor

kirs commented Jun 12, 2021

This is great 👏

@bruno- bruno- force-pushed the fiber-scheduler-address_resolve branch from 328bf81 to 36a69c8 Compare June 12, 2021 11:39
@ioquatix ioquatix force-pushed the fiber-scheduler-address_resolve branch from b749aeb to c61a90a Compare June 12, 2021 22:04
@ioquatix ioquatix force-pushed the fiber-scheduler-address_resolve branch from c61a90a to 6291587 Compare June 12, 2021 22:52
@ioquatix ioquatix merged commit 2792acc into ruby:master Jun 14, 2021
@ioquatix ioquatix deleted the fiber-scheduler-address_resolve branch June 14, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants