Add scheduler hook Addrinfo.getaddrinfo.
#4375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
2 times, most recently
from
77ba38a to
b3abaf1
Compare
bruno-
reviewed
Apr 12, 2021
bruno-
reviewed
Apr 12, 2021
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
from
c3b12d4 to
36a7e2f
Compare
|
Sorry, I was planning to review this the past weekend but ran out of time. Will defer to the coming weekend. |
ioquatix
force-pushed
the
fiber-scheduler-address_resolve
branch
from
36a7e2f to
e23ea6b
Compare
|
Rebased on master. |
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
from
e23ea6b to
15df528
Compare
|
I worked on changes we talked on slack:
As for the PR, would it be helpful to get on a zoom and do a "guided review" and explain the context? |
|
I will review this, this weekend. |
ioquatix
commented
Jun 12, 2021
ioquatix
force-pushed
the
fiber-scheduler-address_resolve
branch
from
5cc44ef to
3a878cb
Compare
|
Rebased on master. |
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
from
3a878cb to
8e6635d
Compare
|
cc @kirs |
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
2 times, most recently
from
56e2a7e to
328bf81
Compare
|
This is great 👏 |
bruno-
force-pushed
the
fiber-scheduler-address_resolve
branch
from
328bf81 to
36a69c8
Compare
ioquatix
force-pushed
the
fiber-scheduler-address_resolve
branch
from
b749aeb to
c61a90a
Compare
ioquatix
force-pushed
the
fiber-scheduler-address_resolve
branch
from
c61a90a to
6291587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook allows the fiber scheduler to implement asynchronous DNS lookup.
https://bugs.ruby-lang.org/issues/17370