Add a Module#const_added callback #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
const-added
branch
2 times, most recently
from
3daf02f
to
b2fb199
Compare
|
While the discussion happens in Redmine, what about adding a test about how it behaves with an autoload call? |
Yeah good point. I added a test for the current behavior. It is debatable wether that behavior is "correct". |
casperisfine
force-pushed
the
const-added
branch
from
adf621e
to
22737d6
Compare
[Feature #17881] Works similarly to `method_added` but for constants. ```ruby Foo::BAR = 42 # call Foo.const_added(:FOO) class Foo::Baz; end # call Foo.const_added(:Baz) Foo.autoload(:Something, "path") # call Foo.const_added(:Something) ```
casperisfine
force-pushed
the
const-added
branch
from
22737d6
to
3564a82
Compare
|
The feature was accepted in the last dev meeting. I updated the |
|
There's some OpenSSL failure on MinGW which seems unrelated, other than that CI is green. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/17881
Works similarly to
method_added.This should allow autoloaders like Zeitwerk to forgo usage of TracePoint.
TracePoint works fine, but it's a bit unfortunate that it cause tons of real word application to use an API that is meant for debugging purposes and have performance impact (albeit relatively minor).
Additionally, it would be useful for gems like tapioca to help introspect codebases.