Avoid console input behavior in windows 10 #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid console input behavior in windows 10. This fixes https://bugs.ruby-lang.org/issues/18588 When ANSI versions of PeekConsoleInput read multibyte charactor partially, subsequent ReadFile returns wrong data on newer Windows 10 versions (probably since Windows Terminal introduced). To avoid this, use Unicode version of of PeekConsoleInput/ReadConsole.
nobu
changed the title
YO4
added a commit
to YO4/ruby
that referenced
this pull request
Sep 2, 2022
UnicodeChar with lower byte == 0 has dropped accidentaly this is additional fix for ruby#5634
YO4
added a commit
to YO4/ruby
that referenced
this pull request
Sep 2, 2022
classic console(conhost.exe) reports an input with ALT+NUMPAD as VK_MENU, KeyUp, and uChar!=0. additional fix for ruby#5634
nobu
pushed a commit
that referenced
this pull request
Sep 8, 2022
UnicodeChar with lower byte == 0 has dropped accidentaly this is additional fix for #5634
nobu
pushed a commit
that referenced
this pull request
Sep 8, 2022
classic console(conhost.exe) reports an input with ALT+NUMPAD as VK_MENU, KeyUp, and uChar!=0. additional fix for #5634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid console input behavior in windows 10.
This fixes https://bugs.ruby-lang.org/issues/18588
When ANSI versions of PeekConsoleInput read multibyte charactor partially, subsequent ReadFile returns wrong data on newer Windows 10 versions (probably since Windows Terminal introduced).
To avoid this, use Unicode version of of PeekConsoleInput/ReadConsole.
ref. microsoft/terminal#12626