Remove $LOADED_FEATURES from examples in lib/English.rb
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leafac Thanks! Could you update doc/globals.rdoc to list I will merge once its ready. |
When the docs for `lib/English.rb` were first written [1], `$LOADED_FEATURES` was an alias for `$"` defined in `lib/English.rb`. Currently, however, `$LOADED_FEATURES` is defined in `load.c` along with `$"` itself [2]. Update the documentation present in `lib/English.rb` to reflect that and don't misguide the reader. Also, add `$LOADED_FEATURES` to `doc/globals.rdoc`, which lists globals defined by Ruby internals. [1]: f8c7b41#diff-2c060ee58c8d1169e19a88d41b3f0259L3 [2]: https://github.com/ruby/ruby/blob/5cc1d57c3957ecabe02c5ad79dd75c523457187f/load.c#L1179
|
There you go @zzak, thanks! |
|
@leafac Thanks! <3 |
mmasaki
pushed a commit
to mmasaki/ruby
that referenced
this pull request
Jun 22, 2014
markjlorenz
pushed a commit
to covermymeds/ruby
that referenced
this pull request
Jun 30, 2014
|
👍 -- BTW: the "docu bug" was introduced as a side-effect of 6dcbfbc |
hsbt
pushed a commit
to ruby/English
that referenced
this pull request
Feb 13, 2020
Patch submitted by @leafac in ruby/ruby#620 * doc/globals.rdoc: Added $LOADED_FEATURES to list git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the docs for
lib/English.rbwere first written 1,$LOADED_FEATURESwas an alias for$"defined inlib/English.rb.Currently, however,
$LOADED_FEATURESis defined inload.calong with$"itself 2.Update the documentation present in
lib/English.rbto reflect that anddon't misguide the reader.