Merged
Conversation
casperisfine
force-pushed
the
str-interpolation-perf
branch
2 times, most recently
from
6b62ff7 to
5222cb4
Compare
That's about 1.30x faster.
We don't need it, and in string interpolation context that's the common case.
casperisfine
force-pushed
the
str-interpolation-perf
branch
from
5222cb4 to
2473a4c
Compare
casperisfine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
rb_str_buf_appendinstead ofrb_enc_cr_str_buf_catshows a1.30ximprovement on the micro benchmark.Skipping the method lookup in
vm_objtostringshows and extra1.10x, for a total of1.40x.