Sort files and test_files in specifications#2524
Merged
1 commit merged intoJan 4, 2019
Merged
Conversation
Currently, when writing out specifications, the order of the elements in files and test_files can differ. Even if the set of files (in the mathematical sense) is the same, the different order causes the files or test_files to look different. This causes problems with the reproducibility of working with specifications. You can install a gem on different machines, and get gemspecs that differ. This change sorts the files and test_files, to protect against the specifications differing unnecessarily.
|
Thanks for opening a pull request and helping make RubyGems better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
Member
|
Thanks for the PR! This will need a test before we consider merging this. |
Member
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Jan 4, 2019
2524: Sort files and test_files in specifications r=hsbt a=cbaines # Description: Currently, when writing out specifications, the order of the elements in files and test_files can differ. Even if the set of files (in the mathematical sense) is the same, the different order causes the files or test_files to look different. This causes problems with the reproducibility of working with specifications. You can install a gem on different machines, and get gemspecs that differ. This change sorts the files and test_files, to protect against the specifications differing unnecessarily. ______________ # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [x] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2574: Removed needless condition for old versions of Ruby. r=hsbt a=hsbt # Description: Fixed #2569 ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Christopher Baines <mail@cbaines.net> Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
Build succeeded |
ghost
merged commit 
Contributor
|
It looks like a test was never added? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, when writing out specifications, the order of the elements
in files and test_files can differ. Even if the set of files (in the
mathematical sense) is the same, the different order causes the files
or test_files to look different.
This causes problems with the reproducibility of working with
specifications. You can install a gem on different machines, and get
gemspecs that differ.
This change sorts the files and test_files, to protect against the
specifications differing unnecessarily.
Tasks:
I will abide by the code of conduct.