Failing test cases for requirements range expressions and prereleases#350
Closed
dekellum wants to merge 6 commits into
Closed
Failing test cases for requirements range expressions and prereleases#350dekellum wants to merge 6 commits into
dekellum wants to merge 6 commits into
Conversation
Member
|
Prereleases were always intended to be a "buyer beware" or "I know what I'm doing" feature. Users of prereleases are expected to pay attention to potential bugs in the releases they install. Due to the potential for bugs they'll need to be sure they're using the latest prerelease and upgrade to the latest version after the official release. I don't think it's worth our time to attempt to implement a fix for these failing test cases. We will review a patch that addresses the failures you have created here. I'm moving this issue from the 2.0 milestone. |
Contributor
|
Checking in to see if there is interest here or should we just close this one. |
Contributor
|
IMHO its fine to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an oddity, continued from #349:
Prereleases are included in
>=,<requirement ranges, even when they don't have prerelease segments. But anyone specifying for example< 1.5.0is most certainly not expecting to use 1.5.0.beta.0 if they happen to have it installed.Failed test output:
Also, a command line example:
Is this all expected behavior?