Skip to content

Add better specification policy error description - #4658

Merged
deivid-rodriguez merged 2 commits into
ruby:masterfrom
ceritium:better-scpecification-policy-error-description
Jun 8, 2021
Merged

Add better specification policy error description#4658
deivid-rodriguez merged 2 commits into
ruby:masterfrom
ceritium:better-scpecification-policy-error-description

Conversation

@ceritium

@ceritium ceritium commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

What was the end-user or developer problem that led to this PR?

Make easier find what key of metadata from gemspec is invalid.

What is your fix for the problem, implemented in this PR?

Print metadata['#{key}'] for string type and length value checks like for link keys.

Make sure the following tasks are checked

@ceritium
ceritium marked this pull request as ready for review June 7, 2021 11:55

@olleolleolle olleolleolle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a useful developer experience improvement.

It would shorten the time it took for a user to correct their mistake.

Comment thread lib/rubygems/specification_policy.rb Outdated

@deivid-rodriguez deivid-rodriguez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💪

@deivid-rodriguez
deivid-rodriguez merged commit 8eb1279 into ruby:master Jun 8, 2021
deivid-rodriguez added a commit that referenced this pull request Jun 11, 2021
…rror-description

Add better specification policy error description

(cherry picked from commit 8eb1279)
@ceritium
ceritium deleted the better-scpecification-policy-error-description branch September 1, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants