Deprecate --install flag to bundle remove and trigger install by default

[ceritium]

Closes #4889

What was the end-user or developer problem that led to this PR?

bundle remove does not update lockfile.

What is your fix for the problem, implemented in this PR?

• Trigger install command by default on bundle remove
• Remove option --install from the cli

[deivid-rodriguez]

Nice job! My only concern here, is that to be nice citizens we should deprecate the --install flag instead of abruptly removing it.

[ceritium]

@deivid-rodriguez I agree with you, then we should:

1. Accept the --install argument and print a deprecation warning
2. Trigger the "install command" by default OR keep the existing behavior and only install by default when we eventually remove the --install argument?
3. Decide when finally remove the --install. Do you think that Bundler 3 is appropriate, or can we do it earlier? I think that there is no hurry.

What do you think?

[deivid-rodriguez]

I'd go with

Trigger the "install command" by default

And in the deprecation warning tell the user to not use it, since it's the default behaviour of bundle remove.

Decide when finally remove the --install. Do you think that Bundler 3 is appropriate, or can we do it earlier? I think that there is no hurry.

Yes, we can remove it in bundler 3.

[deivid-rodriguez]

Just a couple of minor comments, but other than that looks good!

[ceritium]

@deivid-rodriguez, do you think it makes sense to add a pending test for bundler 3 like bundle show --outdated

[deivid-rodriguez]

One final nitpick 😝

[deivid-rodriguez]

@deivid-rodriguez, do you think it makes sense to add a pending test for bundler 3 like bundle show --outdated

Sure, yeah!

[deivid-rodriguez]

👍

[ceritium]

@deivid-rodriguez Do you need me to squash the commits or can you do it on merge?

[deivid-rodriguez]

Actually, if you can do that it'd be awesome! I suspect our backport scripts require explicit merge commits, so we have "squash and merge" disabled.

[deivid-rodriguez]

Thanks!

[ceritium]

@deivid-rodriguez thanks to you. I learn a lot about how the test suite works inside bundler.