Add mswin support for cargo builder#6167
Merged
Merged
Conversation
simi
approved these changes
Dec 21, 2022
Contributor
Author
|
Squashed my commits |
This was referenced May 5, 2023
nobu
reviewed
Feb 13, 2024
Comment on lines
+18
to
+19
| when /^-l\s*([^:\s])+/ # -lfoo, but not -l:libfoo.a | ||
| ["-l", $1] |
Member
There was a problem hiding this comment.
When matching "-lfoo", $1 will be the last letter "o" only.
Is this expected?
And when /^-l\s*(\w+\S+)$/ covers "-lfoo", so this when clause only matches -l with a punctuation, such as "-l-foo".
Is this expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rb-systo make CargoBuilder work properly on mswin--cfg rubygemsand--cfg rubygems_X_X_Xas cargo config for integration points