Permalink
Browse files

Fix the --encoding spec to use an ASCII-compatible encoding

* Patch based on @MSP-Greg fix in
  MSP-Greg/ruby@91e8e2a
  • Loading branch information...
eregon committed Aug 28, 2018
1 parent 34d7519 commit 6fd94725036dd0dc6ceef96c02d443de1cf2b33e
Showing with 8 additions and 7 deletions.
  1. +8 −7 command_line/dash_encoding_spec.rb
@@ -1,29 +1,30 @@
require_relative '../spec_helper'
describe 'The --encoding command line option' do
describe "The --encoding command line option" do
before :each do
@test_string = "print [Encoding.default_external.name, Encoding.default_internal&.name].inspect"
@enc2 = Encoding::ISO_8859_1
end
describe 'sets Encoding.default_external and optionally Encoding.default_internal' do
describe "sets Encoding.default_external and optionally Encoding.default_internal" do
it "if given a single encoding with an =" do
ruby_exe(@test_string, options: '--disable-gems --encoding=big5').should == [Encoding::Big5.name, nil].inspect
ruby_exe(@test_string, options: "--disable-gems --encoding=big5").should == [Encoding::Big5.name, nil].inspect
end
it "if given a single encoding as a separate argument" do
ruby_exe(@test_string, options: '--disable-gems --encoding big5').should == [Encoding::Big5.name, nil].inspect
ruby_exe(@test_string, options: "--disable-gems --encoding big5").should == [Encoding::Big5.name, nil].inspect
end
it "if given two encodings with an =" do
ruby_exe(@test_string, options: '--disable-gems --encoding=big5:utf-32be').should == [Encoding::Big5.name, Encoding::UTF_32BE.name].inspect
ruby_exe(@test_string, options: "--disable-gems --encoding=big5:#{@enc2}").should == [Encoding::Big5.name, @enc2.name].inspect
end
it "if given two encodings as a separate argument" do
ruby_exe(@test_string, options: '--disable-gems --encoding big5:utf-32be').should == [Encoding::Big5.name, Encoding::UTF_32BE.name].inspect
ruby_exe(@test_string, options: "--disable-gems --encoding big5:#{@enc2}").should == [Encoding::Big5.name, @enc2.name].inspect
end
end
it "does not accept a third encoding" do
ruby_exe(@test_string, options: '--disable-gems --encoding big5:utf-32be:utf-32le', args: '2>&1').should =~ /extra argument for --encoding: utf-32le/
ruby_exe(@test_string, options: "--disable-gems --encoding big5:#{@enc2}:utf-32le", args: "2>&1").should =~ /extra argument for --encoding: utf-32le/
end
end

0 comments on commit 6fd9472

Please sign in to comment.