Skip to content

Specs for StringIO#sysread and StringIO#read_nonblock #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Specs for StringIO#sysread and StringIO#read_nonblock #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343f112
Fix shared spec to use send(@method) instead of hardcoded method name
herwinw Oct 10, 2024
d738189
Additional shared spec for StringIO#sysread
herwinw Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/stringio/shared/sysread.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@

it "raises an EOFError when passed length > 0 and no data remains" do
@io.read.should == "example"
-> { @io.sysread(1) }.should raise_error(EOFError)
-> { @io.send(@method, 1) }.should raise_error(EOFError)
end
end
5 changes: 5 additions & 0 deletions library/stringio/sysread_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
require_relative '../../spec_helper'
require "stringio"
require_relative 'shared/read'
require_relative 'shared/sysread'

describe "StringIO#sysread when passed length, buffer" do
it_behaves_like :stringio_read, :sysread
Expand Down Expand Up @@ -32,6 +33,10 @@
end
end

describe "StringIO#sysread when passed length" do
it_behaves_like :stringio_sysread_length, :sysread
end

describe "StringIO#sysread when passed [length]" do
before :each do
@io = StringIO.new("example")
Expand Down