Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require round-to-nearest-even behavior for Ruby 2.4+ #322

Merged
merged 2 commits into from Nov 5, 2016

Conversation

@noahgibbs
Copy link
Contributor

@noahgibbs noahgibbs commented Oct 20, 2016

But require round-to-nearest before that.

+2.5e20.round(-20).should eql( +3 * 10 ** 20 )
-2.5e20.round(-20).should eql( -3 * 10 ** 20 )
end
end
Copy link
Member

@eregon eregon Oct 20, 2016

Could you swap these two ìt` so the 2.4 behavior comes after the < 2.4 behavior?

Copy link
Contributor Author

@noahgibbs noahgibbs Oct 20, 2016

Absolutely. Pushed.

@eregon
Copy link
Member

@eregon eregon commented Oct 20, 2016

It looks great, thanks for adapting the specs!
As soon as the change is in MRI we can merge this 😃

@nobu nobu merged commit 5eb8b40 into ruby:master Nov 5, 2016
2 checks passed
@github-staff github-staff deleted a comment Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants