Skip to content

LSP: Support instance variable definition jump #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Aug 10, 2021

Description

Added support of Go to instance variable definition.

Known Issue

In get_foo, @foo can't find the its definition in set_foo due to the limitation of current identify_class_for_ivar analysis

class A
  def set_foo
    @foo = 1
  end
end

class B < A
  def get_foo
    @foo
  end
end

Demo

Screen.Recording.2021-08-10.at.16.58.19.mov

@kateinoigakukun kateinoigakukun changed the title Support instance-variable definition jump LSP: Support instance variable definition jump Aug 10, 2021
@mame mame merged commit 7433209 into ruby:lsp-test Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants