Skip to content

LSP: Support instance variable definition jump - #39

Merged
mame merged 1 commit into
ruby:lsp-testfrom
kateinoigakukun:katei/ivar-go-to-def
Aug 10, 2021
Merged

LSP: Support instance variable definition jump#39
mame merged 1 commit into
ruby:lsp-testfrom
kateinoigakukun:katei/ivar-go-to-def

Conversation

@kateinoigakukun

@kateinoigakukun kateinoigakukun commented Aug 10, 2021

Copy link
Copy Markdown
Member

Description

Added support of Go to instance variable definition.

Known Issue

In get_foo, @foo can't find the its definition in set_foo due to the limitation of current identify_class_for_ivar analysis

class A
  def set_foo
    @foo = 1
  end
end

class B < A
  def get_foo
    @foo
  end
end

Demo

Screen.Recording.2021-08-10.at.16.58.19.mov

@kateinoigakukun kateinoigakukun changed the title Support instance-variable definition jump LSP: Support instance variable definition jump Aug 10, 2021
@mame
mame merged commit 7433209 into ruby:lsp-test Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants