Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian Language #2175

Open
wants to merge 23 commits into
base: master
from
Open

Add Persian Language #2175

wants to merge 23 commits into from

Conversation

@Goudarz
Copy link

Goudarz commented Oct 18, 2019

No description provided.

Goudarz and others added 17 commits Aug 9, 2017
update repo
update repo
Repo Update
Update repo
update repo
Update Repo
Update Repo
Update Repo
Update Repo
@Goudarz Goudarz requested a review from ruby/www-ruby-lang-org-editorial as a code owner Oct 18, 2019
Goudarz added 6 commits Oct 18, 2019
@hsbt

This comment has been minimized.

Copy link
Member

hsbt commented Oct 22, 2019

Please rebase from the current master branch. We should ignore the Merge commit from master branch.

@stomar

This comment has been minimized.

Copy link
Contributor

stomar commented Nov 6, 2019

First some general remarks:

It should be certain before any PRs that there are enough maintainers/translators.
Abandoned and out-of-date translations are worse than having none at all. And with a single responsible person this happens very easily (and did happen).

Adding a new translation involves a lot of work, both in preparation and afterwards:

  • all static content must be translated before the site goes live,
  • later on all new posts about vulnerabilities and new releases must be translated, and the content needs to be kept up-to-date with the original en site.

See also the milestones for #699 to get an impression of the work involved during the initial translation process, and the discussion #670.

This may sound a little discouraging, but please keep in mind that a new translation causes a lot of work for us maintainers, too.

As soon as it is sure that there is a team of at least say 3 persons who will show that kind of commitment, we can discuss the details on how to best proceed.

Please do not provide PRs right now.

Regarding this PR: even after a only cursory review there are several issues, like e.g. merge commits, or duplicated English content instead of translations, or added files that do not belong here at all, ..., and on the whole much too many changes, also changes of general configuration files or stylesheets that need extra care in reviewing and possibly some discussion. It cannot be merged. (Also, work in progress should not be merged into the master branch, since that's what gets deployed regularly.)

@Goudarz

This comment has been minimized.

Copy link
Author

Goudarz commented Nov 8, 2019

The reason that the translation took so much time was me being by my self and I'm really sorry about that.

But now we have a team. me, @AsefJ and @TwistedMiles and we understood #699 #670.

We are ready to discuss details.

@stomar stomar self-assigned this Nov 9, 2019
@stomar

This comment has been minimized.

Copy link
Contributor

stomar commented Nov 9, 2019

I'll need to do some basic setup, then I'll open a new issue with milestones for tracking the progress.

@stomar

This comment has been minimized.

Copy link
Contributor

stomar commented Nov 19, 2019

I'm in the process of improving some configuration setup, e.g. handling of locales data, which should be completed before starting on the new translation to avoid later merge conflicts.

@stomar

This comment has been minimized.

Copy link
Contributor

stomar commented Nov 19, 2019

In the meantime, could the other contributors please leave a short comment here?

And one general question beforehand: is it necessary to require a specific font? Other translations do not do that.

@Goudarz

This comment has been minimized.

Copy link
Author

Goudarz commented Nov 28, 2019

Hey there, Sorry for my late respond, We had internet blackout since last week.

And one general question beforehand: is it necessary to require a specific font? Other translations do not do that.

It is better to use standard fonts for better readability since the Persian language uses Arabic script.

@TwistedMiles

This comment has been minimized.

Copy link

TwistedMiles commented Nov 28, 2019

Hello,
Yes there was the internet blackout and now were crossing our fingers for Mobile internet providers to "turn on the internet".

@AsefJ

This comment has been minimized.

Copy link

AsefJ commented Nov 29, 2019

Hello,
Well! I'm ready for it. Let's do it!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.