Skip to content

Conversation

@gmitrev
Copy link
Member

@gmitrev gmitrev commented Dec 7, 2014

This pull request updates all outdated pages in Bulgarian and also fixes some translation errors. I took the liberty to remove the 'outdated' notices and intend to keep the translation up-to-date.

There is also a branch that isn't squished that can be used if you prefer multiple focused commits instead of a big one.

@gmitrev gmitrev changed the title Updated Bulgarian translations Updated Bulgarian translation Dec 7, 2014
@gmitrev gmitrev force-pushed the update-bulgarian-translation branch from b9419d8 to 65c2d7d Compare December 7, 2014 19:07
@stomar
Copy link
Contributor

stomar commented Dec 7, 2014

@gmitrev Already a big thank you! I will look into the changes tomorrow or the day after.

Also note that the installation page is about to be moved (#911); IMO it makes sense to amend your PR accordingly, as soon as that PR is merged.

@stomar stomar self-assigned this Dec 7, 2014
@gmitrev gmitrev force-pushed the update-bulgarian-translation branch from 65c2d7d to d54eb81 Compare December 8, 2014 08:05
@gmitrev
Copy link
Member Author

gmitrev commented Dec 8, 2014

@stomar The PR is updated and includes the changes from #911.

@stomar
Copy link
Contributor

stomar commented Dec 8, 2014

Note also recent change of the installation page content.

@gmitrev gmitrev force-pushed the update-bulgarian-translation branch from d54eb81 to 0108441 Compare December 8, 2014 08:33
@gmitrev
Copy link
Member Author

gmitrev commented Dec 8, 2014

👍 I will update it when #914 get's merged in.

@gmitrev gmitrev force-pushed the update-bulgarian-translation branch from 0108441 to 58762e5 Compare December 11, 2014 19:10
@gmitrev
Copy link
Member Author

gmitrev commented Dec 11, 2014

Just pushed another update that includes all recent changes. Let me know if there is anything else that needs to be done.

@stomar
Copy link
Contributor

stomar commented Dec 11, 2014

I'm very busy right now; noticed already 2 or 3 things, but closer look needs to wait until the weekend...

@stomar
Copy link
Contributor

stomar commented Dec 13, 2014

@gmitrev

Great work, I only noticed very few things:

  • bg/about/index.md: Matz' quote is missing, and the corresponding link
  • bg/community/conferences/index.md: some regional conferences are missing, which is ok, but the common link references should be synchronized (having same number)
  • bg/community/mailing-lists/manual-instructions/index.md: also needs a small update

I did another small change on installation: regarding Arch Linux, it's better to provide information in a way that doesn't "age" as fast as mentioning a specific version number.

AND (but I suggest a different PR for this):

  • _config.yml: some localizations are missing, e.g. mailing list subscription
  • also in _config.yml: credits are out-dated
  • missing: about/logo, about/website

@gmitrev gmitrev force-pushed the update-bulgarian-translation branch from 58762e5 to 91de6df Compare December 14, 2014 15:42
@gmitrev
Copy link
Member Author

gmitrev commented Dec 14, 2014

@stomar

Thank you for your feedback! I just pushed the fixes.

I am not sure if I understood the point about bg/community/conferences/index.md so I just synced the references with the ones from the English version. Is that correct?

I will also start to work on your suggestions as soon as I can find some time.

stomar added a commit that referenced this pull request Dec 14, 2014
@stomar stomar merged commit 20bf278 into ruby:master Dec 14, 2014
@stomar
Copy link
Contributor

stomar commented Dec 14, 2014

👏 🎆 Thanks for the effort, it's a great improvement of the bg section!

(BTW, you did exactly what I meant on the community page.)

@gmitrev gmitrev deleted the update-bulgarian-translation branch December 14, 2014 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants