Add compile
task in Development section
#80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I followed the instructions in the Development section, I found some tests failing with Ruby 3.3.1 and older Rubies:
failure log
It turned out that this was because I had not executed the
rake compile
before runningrake test
.We should have
compile
task in the Development section so that new contributors don't stumble.FYI: CI runs
rake compile test
.zlib/.github/workflows/test.yml
Line 42 in 950dad7