Wrong variable names at AbstractTicketStore, get_session_for_service_ticket method #30

Closed
Buguito opened this Issue Dec 28, 2011 · 0 comments

Comments

Projects
None yet
2 participants

Buguito commented Dec 28, 2011

You're receiving "st" as parameter, and using "si" in the read_service_session_lookup(si) call, and also at the logger. This crashes obviously.

Happened to me while attempting to use the single sign out. Without this fixed, i don't know how anyone could make that feature work.

def get_session_for_service_ticket(st)
session_id = read_service_session_lookup(si)
if session_id
session = ActiveRecord::SessionStore::Session.find_by_session_id(session_id)
else
log.warn("Couldn't destroy session with SessionIndex #{si} because no corresponding session id could be looked up.")
end
[session_id, session]
end

I'm using the gem 2.3.8 btw.

Best regards, Alan //

soupmatt closed this in fac373f Feb 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment