Support for phtml FileType #122

Merged
merged 2 commits into from May 5, 2013

Projects

None yet

2 participants

@alexandrevez

In most cases, phtml files are html/javascripts with small PHP content.

I regesitered the filetype.

@korny
Ruby-chan member

So why not use the PHP scanner?

@alexandrevez

Because it's mostly javascript and HTML in the file.

@korny
Ruby-chan member

Okay, but the PHP scanner already supports HTML with JavaScript…

@korny
Ruby-chan member

Can you please check if 'phtml' => :php, does what you want? :-)

@alexandrevez
@korny
Ruby-chan member

Okay, great! I'll merge the PR when you update it accordingly.

@korny korny merged commit 25ea056 into rubychan:master May 5, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment