Skip to content

Download Court Report UI Change#2001

Merged
compwron merged 2 commits into
rubyforgood:mainfrom
ChaelCodes:1648-download-court-report-spinner
May 13, 2021
Merged

Download Court Report UI Change#2001
compwron merged 2 commits into
rubyforgood:mainfrom
ChaelCodes:1648-download-court-report-spinner

Conversation

@ChaelCodes

Copy link
Copy Markdown
Contributor

What github issue is this PR for, if any?

Resolves #1648

What changed, and why?

Replaced massive button of text with a spinner.

  • If you would like me to swap the hourglass with a fa-spinner, I'd be happy to do so.

Automatically download instead of showing a button

  • I'm concerned about this causing issues with pop-up blockers. I've made all the changes in a separate commit, so it can be easily dropped or reverted if there are issues in QA.

How will this affect user permissions?

  • Volunteer permissions: N/A
  • Supervisor permissions: N/A
  • Admin permissions: N/A

How is this tested? (please write tests!) 💖💪

Through systems tests!

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

@compwron

compwron commented May 3, 2021

Copy link
Copy Markdown
Collaborator

This is looking WONDERFUL! I am excite :)

@ChaelCodes ChaelCodes force-pushed the 1648-download-court-report-spinner branch from e7d05be to 83d387b Compare May 9, 2021 15:25
@ChaelCodes ChaelCodes force-pushed the 1648-download-court-report-spinner branch from 57473a1 to f838b23 Compare May 9, 2021 15:53
@ChaelCodes ChaelCodes force-pushed the 1648-download-court-report-spinner branch from b07961b to ff6add2 Compare May 9, 2021 17:31
@ChaelCodes ChaelCodes marked this pull request as ready for review May 9, 2021 17:38

@compwron compwron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@compwron compwron merged commit b60e26d into rubyforgood:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download Court Report UI change - one button instead of two

2 participants