Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require InventoryItems for all Items? #1078

Closed
mdworken opened this issue Jun 25, 2019 · 3 comments

Comments

@mdworken
Copy link
Member

commented Jun 25, 2019

One example reproduction path:

  • Create a donation using an item.
  • Create a distribution that will make that item's inventory 0.
  • Edit the donation

Expected behavior: the item is pre-selected
Actual behavior: the first item in the list is pre-selected (because the item is inactive)

This bug is especially dangerous as it can change quantity just by hitting edit and save without the user making any deliberate changes.

@mdworken mdworken added the bug label Jun 25, 2019

@mdworken mdworken self-assigned this Jun 29, 2019

@mdworken

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

After further investigation - it appears that the bug reported above has been previously fixed, and the current bug I'm seeing is caused by Distributions that have Items that do NOT have InventoryItems. Will keep digging, but I'm now starting to suspect this is a problem with seed data.

@mdworken mdworken changed the title Allow inactive Items to still default in pulldowns for #edit pages Require InventoryItems for all Items? Jul 13, 2019

@awwaiid

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2019

Fixed by #1077?

@awwaiid awwaiid added the question label Jul 28, 2019

@armahillo

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

This appears to be addressed by #1088 -- please re-open if not!

@armahillo armahillo closed this Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.