Skip to content
This repository has been archived by the owner. It is now read-only.

[Definition] Print a helpful warning when a dependency is unused on a… #5003

Merged
merged 2 commits into from Sep 30, 2016

Conversation

@segiddins
Copy link
Member

@segiddins segiddins commented Sep 19, 2016

…ny platform

Should help address the confusion caused by https://github.com/bundler/bundler/issues/5001

@indirect
Copy link
Member

@indirect indirect commented Sep 20, 2016

This is a good warning! That said, I'm not sure how this fixes the bug described in #5001. In that ticket, the Gemfile no longer contains a platform declaration at all, and the gem is still ignored. Seems like a different problem.

@segiddins
Copy link
Member Author

@segiddins segiddins commented Sep 20, 2016

That's not fixable without completely re-writing large parts of definition.

@indirect
Copy link
Member

@indirect indirect commented Sep 20, 2016

Assuming that is true, it still doesn't change the fact that this is solving a different problem than the one reported in #5001, does it?

@segiddins
Copy link
Member Author

@segiddins segiddins commented Sep 20, 2016

No, but it might help address the confusion by printing a warning in that case (saying that something out of the ordinary is taking place)

@indirect
Copy link
Member

@indirect indirect commented Sep 30, 2016

@homu r+

@homu
Copy link
Contributor

@homu homu commented Sep 30, 2016

📌 Commit f7f6087 has been approved by indirect

homu added a commit that referenced this pull request Sep 30, 2016
[Definition] Print a helpful warning when a dependency is unused on a…

…ny platform

Should help address the confusion caused by https://github.com/bundler/bundler/issues/5001
@homu
Copy link
Contributor

@homu homu commented Sep 30, 2016

Testing commit f7f6087 with merge 5ee7613...

@homu
Copy link
Contributor

@homu homu commented Sep 30, 2016

☀️ Test successful - status

@homu homu merged commit f7f6087 into master Sep 30, 2016
3 checks passed
3 checks passed
@segiddins
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@homu
homu Test successful
Details
@lynncyrin lynncyrin modified the milestone: 1.13 - Release 1.13.2 Sep 30, 2016
@segiddins segiddins deleted the seg-warn-unused-deps branch Dec 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants