This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] [Resolver] Error when it is ambigous which transitive source a gem should come from #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
changed the title
segiddins
force-pushed
the
seg-multisource-error
branch
2 times, most recently
from
7588b8a
to
f096219
Compare
segiddins
force-pushed
the
seg-multisource-error
branch
from
f096219
to
789974c
Compare
|
@indirect r? |
|
This looks right to me! @bundlerbot r+ |
|
📌 Commit 789974c has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Sep 10, 2017
[2.0] [Resolver] Error when it is ambigous which transitive source a gem should come from ### What was the end-user problem that led to this PR? The problem was the "source priority" in ambiguous source situations was ... ambiguous. ### What was your diagnosis of the problem? My diagnosis was we should error and require a user explicitly pin the dependency to a source in those situations, rather than leaving the source used up to an implementation detail. ### What is your fix for the problem, implemented in this PR? My fix attempts to implement the priority described in the conversation in #4629. ### Why did you choose this fix out of the possible options? I chose this fix because it still allows using the default source as a backup, while only taking the "relevant" sources into account, so that the error/warning is not overzealous.
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was the "source priority" in ambiguous source situations was ... ambiguous.
What was your diagnosis of the problem?
My diagnosis was we should error and require a user explicitly pin the dependency to a source in those situations, rather than leaving the source used up to an implementation detail.
What is your fix for the problem, implemented in this PR?
My fix attempts to implement the priority described in the conversation in #4629.
Why did you choose this fix out of the possible options?
I chose this fix because it still allows using the default source as a backup, while only taking the "relevant" sources into account, so that the error/warning is not overzealous.