Skip to content
This repository has been archived by the owner. It is now read-only.

Gemspec require relative #7137

Merged
2 commits merged into from Apr 26, 2019
Merged

Gemspec require relative #7137

2 commits merged into from Apr 26, 2019

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Apr 23, 2019

What was the end-user problem that led to this PR?

This is a follow up to #7100. Gemspec is another place where require_relative sounds like a win.

What is your fix for the problem, implemented in this PR?

My fix changes bundler's gemspec to use require_relative, and extracts the relevant change from #4397 to also change the generated gemspec from bundle gem.

@duckinator
Copy link
Member

duckinator commented Apr 26, 2019

require_relative is definitely a huge win here. Looks good. 👍

@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Apr 26, 2019

Going in!

@bundlerbot r+

ghost pushed a commit that referenced this issue Apr 26, 2019
7137: Gemspec require relative r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

This is a follow up to #7100. Gemspec is another place where `require_relative` sounds like a win.

### What is your fix for the problem, implemented in this PR?

My fix changes bundler's gemspec to use `require_relative`, and extracts the relevant change from #4397 to also change the generated gemspec from `bundle gem`.

Co-authored-by: Miklos Fazekas <mfazekas@szemafor.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Apr 26, 2019

Build succeeded

@ghost ghost merged commit 2478e34 into master Apr 26, 2019
3 checks passed
@ghost ghost deleted the gemspec_require_relative branch Apr 26, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants