Skip to content
This repository has been archived by the owner. It is now read-only.

Fix bundle clean issue #7340

Merged
3 commits merged into from Sep 4, 2019
Merged

Fix bundle clean issue #7340

3 commits merged into from Sep 4, 2019

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Sep 1, 2019

What was the end-user problem that led to this PR?

The problem was that bundle clean is crashing under some conditions.

What was your diagnosis of the problem?

My diagnosis was that sometimes (when the bundle includes git sourced gems with extensions), it assumes that some paths exist, but they don't.

What is your fix for the problem, implemented in this PR?

My fix is to ignore those paths.

Why did you choose this fix out of the possible options?

I chose this fix because it fixes the issue.

Fixes #7338.

It would crash when git gems with extensions were included in the
bundle, but excluded through `BUNDLE_WITHOUT`.
@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Sep 1, 2019

@mattbrictson Can you double check that this change fixes the problem for you?

@deivid-rodriguez deivid-rodriguez added this to the 2.1.0.pre.2 milestone Sep 1, 2019
@mattbrictson
Copy link
Contributor

mattbrictson commented Sep 1, 2019

This fixes the issue for me. Thanks for the quick turnaround! 🙇

@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Sep 4, 2019

This PR includes a regression test, and the OP has confirmed it fixes the issue, so I'll go ahead and merge it!

@bundlerbot r+

ghost pushed a commit that referenced this issue Sep 4, 2019
7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that `bundle clean` is crashing under some conditions.

### What was your diagnosis of the problem?

My diagnosis was that sometimes (when the bundle includes git sourced gems with extensions), it assumes that some paths exist, but they don't.

### What is your fix for the problem, implemented in this PR?

My fix is to ignore those paths.

### Why did you choose this fix out of the possible options?

I chose this fix because it fixes the issue.

Fixes #7338.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Sep 4, 2019

Build succeeded

@ghost ghost merged commit 6163d00 into master Sep 4, 2019
4 checks passed
@ghost ghost deleted the fix_bundle_clean_issue branch Sep 4, 2019
deivid-rodriguez pushed a commit that referenced this issue Sep 15, 2019
7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that `bundle clean` is crashing under some conditions.

### What was your diagnosis of the problem?

My diagnosis was that sometimes (when the bundle includes git sourced gems with extensions), it assumes that some paths exist, but they don't.

### What is your fix for the problem, implemented in this PR?

My fix is to ignore those paths.

### Why did you choose this fix out of the possible options?

I chose this fix because it fixes the issue.

Fixes #7338.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit b007fde)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants