Skip to content
This repository has been archived by the owner. It is now read-only.

Lazily load open3 #7455

Merged
1 commit merged into from Nov 26, 2019
Merged

Lazily load open3 #7455

1 commit merged into from Nov 26, 2019

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Nov 26, 2019

What was the end-user problem that led to this PR?

The problem was open3 will be gemified in ruby 2.7, and since we use it inside bundler, we might activate a version causing a conflict with the user's choice.

What was your diagnosis of the problem?

My diagnosis was that only loading it when needed should be better.

What is your fix for the problem, implemented in this PR?

My fix is to lazily load it.

I expect this PR to fix some of the errors currently happening in our CI against ruby-head.

Since it's a default gem now, it's better to load it as late as
possible.
@deivid-rodriguez deivid-rodriguez added this to the 2.1.0.rc milestone Nov 26, 2019
@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Nov 26, 2019

@bundlerbot merge

ghost pushed a commit that referenced this issue Nov 26, 2019
7455: Lazily load `open3` r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was `open3` will be gemified in ruby 2.7, and since we use it inside `bundler`, we might activate a version causing a conflict with the user's choice.

### What was your diagnosis of the problem?

My diagnosis was that only loading it when needed should be better.

### What is your fix for the problem, implemented in this PR?

My fix is to lazily load it.

I expect this PR to fix [some of the errors](https://travis-ci.org/bundler/bundler/jobs/615940817) currently happening in our CI against ruby-head.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Nov 26, 2019

Build succeeded

@ghost ghost merged commit aac6e6d into master Nov 26, 2019
3 checks passed
@ghost ghost deleted the lazily_load_open3 branch Nov 26, 2019
@deivid-rodriguez deivid-rodriguez modified the milestones: 2.1.0.rc, 2.1.0 Dec 13, 2019
deivid-rodriguez pushed a commit that referenced this issue Dec 13, 2019
7455: Lazily load `open3` r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was `open3` will be gemified in ruby 2.7, and since we use it inside `bundler`, we might activate a version causing a conflict with the user's choice.

### What was your diagnosis of the problem?

My diagnosis was that only loading it when needed should be better.

### What is your fix for the problem, implemented in this PR?

My fix is to lazily load it.

I expect this PR to fix [some of the errors](https://travis-ci.org/bundler/bundler/jobs/615940817) currently happening in our CI against ruby-head.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit 2a5378c)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant