Skip to content
This repository has been archived by the owner. It is now read-only.

Lazily load CGI #7456

Merged
1 commit merged into from Nov 27, 2019
Merged

Lazily load CGI #7456

1 commit merged into from Nov 27, 2019

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Nov 27, 2019

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

What was the end-user problem that led to this PR?

The problem was that our ruby-head build is failing in CI.

What was your diagnosis of the problem?

My diagnosis was that since cgi is now a default gem on ruby 2.7, we're getting someunintended activations of the new default gem inside our specs.

What is your fix for the problem, implemented in this PR?

My fix is to lazily load CGI.

Since cgi is now a default gem on ruby 2.7, we're getting some
unintended activations of the new default gem inside our specs.
@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Nov 27, 2019

@bundlerbot merge

ghost pushed a commit that referenced this issue Nov 27, 2019
7456: Lazily load CGI r=deivid-rodriguez a=deivid-rodriguez



Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

### What was the end-user problem that led to this PR?

The problem was that our ruby-head build is failing in CI.

### What was your diagnosis of the problem?

My diagnosis was that since `cgi` is now a default gem on ruby 2.7, we're getting someunintended activations of the new default gem inside our specs.

### What is your fix for the problem, implemented in this PR?

My fix is to lazily load CGI.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Nov 27, 2019

Build succeeded

@ghost ghost merged commit 085fb8d into master Nov 27, 2019
3 checks passed
@ghost ghost deleted the lazily_load_cgi branch Nov 27, 2019
@deivid-rodriguez deivid-rodriguez modified the milestones: 2.1.0.rc, 2.1.0 Dec 13, 2019
deivid-rodriguez pushed a commit that referenced this issue Dec 13, 2019
7456: Lazily load CGI r=deivid-rodriguez a=deivid-rodriguez

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

### What was the end-user problem that led to this PR?

The problem was that our ruby-head build is failing in CI.

### What was your diagnosis of the problem?

My diagnosis was that since `cgi` is now a default gem on ruby 2.7, we're getting someunintended activations of the new default gem inside our specs.

### What is your fix for the problem, implemented in this PR?

My fix is to lazily load CGI.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit c3eae8e)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant