Skip to content
This repository has been archived by the owner. It is now read-only.

Revert "Write & read dummy gems binarily" #7478

Merged
1 commit merged into from Dec 13, 2019
Merged

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Dec 13, 2019

This reverts commit f11c475.

What was the end-user problem that led to this PR?

The problem was that since #7451, azure logs are flooded with messages like

The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in foo.gemspec.

This makes it hard to scan for other potential errors.

What was your diagnosis of the problem?

My diagnosis was that some commit in that PR introduced this warnings.

What is your fix for the problem, implemented in this PR?

My fix is to revert the offending commit.

@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Dec 13, 2019

@bundlerbot merge

ghost pushed a commit that referenced this issue Dec 13, 2019
7478: Revert "Write & read dummy gems binarily" r=deivid-rodriguez a=deivid-rodriguez

This reverts commit f11c475.


### What was the end-user problem that led to this PR?

The problem was that since #7451, azure logs are flooded with messages like

```
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in foo.gemspec.
```

This makes it hard to scan for other potential errors.

### What was your diagnosis of the problem?

My diagnosis was that some commit in that PR introduced this warnings.

### What is your fix for the problem, implemented in this PR?

My fix is to revert the offending commit.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Dec 13, 2019

Build succeeded

@ghost ghost merged commit 831093c into master Dec 13, 2019
3 checks passed
@ghost ghost deleted the cleanup_windows_ci_logs branch Dec 13, 2019
@deivid-rodriguez deivid-rodriguez added this to the 2.1.0 milestone Dec 13, 2019
deivid-rodriguez pushed a commit that referenced this issue Dec 13, 2019
7478: Revert "Write & read dummy gems binarily" r=deivid-rodriguez a=deivid-rodriguez

This reverts commit f11c475.

### What was the end-user problem that led to this PR?

The problem was that since #7451, azure logs are flooded with messages like

```
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in foo.gemspec.
```

This makes it hard to scan for other potential errors.

### What was your diagnosis of the problem?

My diagnosis was that some commit in that PR introduced this warnings.

### What is your fix for the problem, implemented in this PR?

My fix is to revert the offending commit.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit f143253)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant