Permalink
Commits on May 23, 2017
Commits on May 20, 2017
  1. Merge pull request #1627 from sonalkr132/deprications

    Fix moar deprecations
    sonalkr132 committed on GitHub May 20, 2017
  2. Use class reference and remove raise_in_transactional_callbacks from …

    …config
    
    DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
    them to actual class references.  For example:
      "Redirector" => Redirector
    DEPRECATION WARNING: ActiveRecord::Base.raise_in_transactional_callbacks= is deprecated, has no effect and will be removed without replacement
    DEPRECATION WARNING: `config.serve_static_files` is deprecated and will be removed in Rails 5.1.
    Please use `config.public_file_server.enabled = false` instead.
    sonalkr132 committed May 14, 2017
  3. Use throw :abort to halt callback chain

    DEPRECATION WARNING: Returning `false` in Active Record and Active Model callbacks will not implicitly halt a callback chain in Rails 5.1. To explicitly halt the callback chain, please use `throw :abort` instead.
    sonalkr132 committed May 14, 2017
Commits on May 19, 2017
  1. add sidekiq-pro to blacklist

    dwradcliffe committed on GitHub May 19, 2017
Commits on May 18, 2017
  1. Merge pull request #1628 from sonalkr132/update

    Update rubocop from 0.47.1 to 0.48.1
    sonalkr132 committed on GitHub May 18, 2017
Commits on May 17, 2017
  1. Update rubocop from 0.47.1 to 0.48.1

    fixes:
    * Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ]. (https://github.com/bbatsov/ruby-style-guide#percent-literal-braces)
    * Style/SymbolArray: Use %i or %I for an array of symbols. (https://github.com/bbatsov/ruby-style-guide#percent-i)
    * Rails/Present: Use if platform.present? instead of unless platform.blank?
    * Style/IndentHeredoc: Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-. (https://github.com/bbatsov/ruby-style-guide#squiggly-heredocs)
    * Lint/AmbiguousBlockAssociation: Parenthesize the param execute_raw_sql(query).map { |v| [v['name'], [v]] } to make sure that the block will be associated with the execute_raw_sql(query).map method call. (https://github.com/bbatsov/ruby-style-guide#syntax)
    * Style/InverseMethods: Use none? instead of inverting any?.
    * Rails/Blank: Use if suggestions.blank? instead of unless suggestions.present?
    sonalkr132 committed May 14, 2017
Commits on May 16, 2017
  1. Merge pull request #1603 from sonalkr132/advanced-search-page

    Advanced search page
    sonalkr132 committed on GitHub May 16, 2017
Commits on May 15, 2017
  1. Add advanced search page

    sonalkr132 committed Apr 17, 2017
Commits on May 13, 2017
  1. Merge pull request #1625 from sonalkr132/redirect-deprecation

    Use follow_redirect! instead of post_via_redirect
    sonalkr132 committed on GitHub May 13, 2017
  2. Merge pull request #1626 from sonalkr132/migration-deprecation

    Specify rails version in migration file
    sonalkr132 committed on GitHub May 13, 2017
Commits on May 12, 2017
  1. Specify rails version in migration file

    rails 5.1 would error with:
    StandardError: An error has occurred, all later migrations canceled.
    Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for:
    class CreateBaseline < ActiveRecord::Migration[4.2]
    sonalkr132 committed May 12, 2017
  2. Use follow_redirect! instead of post_via_redirect

    DEPRECATION WARNING: `post_via_redirect` is deprecated and will be removed in Rails 5.1. Please use `follow_redirect!` manually after the request call for the same behavior.
    DEPRECATION WARNING: `render :text` is deprecated because it does not actually render a `text/plain` response.
    DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated.
    
    Turns out, we didn't need all the post_via_redirect we were using.
    sonalkr132 committed May 12, 2017
  3. Update mail from 2.6.5 to 2.6.6.rc1

    Version was specified because we need to update to release candidate
    which has security update
    sonalkr132 committed May 11, 2017
Commits on May 11, 2017
  1. Merge pull request #1608 from hsbt/whitelisted-degault-gems-201705

    Removed blacklist patterns for default gems of Ruby 2.5
    dwradcliffe committed on GitHub May 11, 2017
Commits on May 10, 2017
  1. Merge pull request #1604 from sonalkr132/result-window-too-large

    Limit number of pages on search pagination
    sonalkr132 committed on GitHub May 10, 2017
  2. Merge pull request #1623 from sonalkr132/test-params-deprecation

    Remove positional arguments from requests in test
    sonalkr132 committed on GitHub May 10, 2017
Commits on May 9, 2017
  1. Remove positional arguments from requests in test

    Fixes:
    DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
    in favor of keyword arguments, and will be removed in Rails 5.1.
    Deprecated style:
    get :show, { id: 1 }, nil, { notice: "This is a flash message" }
    New keyword style:
    get :show, params: { id: 1 }, flash: { notice: "This is a flash message" },
      session: nil # Can safely be omitted
    sonalkr132 committed May 9, 2017
  2. Limit number of pages on search pagination

    Fixes: https://app.honeybadger.io/projects/40972/faults/33345740
    It was erroring for large page numbers:
    ```
    org.elasticsearch.search.query.QueryPhaseExecutionException: Result window is too large, from + size must be less than or equal to: [10000] but was [74520].
    ```
    `terminate_after` was considered but it doesn't seem to take precedence
    over `from`.
    sonalkr132 committed Apr 20, 2017
Commits on May 8, 2017
  1. Merge pull request #1614 from sonalkr132/static-csp

    Remove inline style from error pages
    sonalkr132 committed on GitHub May 8, 2017
  2. Merge pull request #1621 from rubygems/email_length_validation

    validate email length
    sonalkr132 committed on GitHub May 8, 2017
Commits on May 7, 2017
  1. validate email length

    dwradcliffe committed May 7, 2017
  2. update vendor/cache

    dwradcliffe committed May 7, 2017
Commits on May 5, 2017
  1. Merge pull request #1619 from sonalkr132/eager-load-lib

    Add lib folder to eager_load_paths
    sonalkr132 committed on GitHub May 5, 2017
  2. Add lib folder to eager_load_paths

    rails 5 doesn't load autoload_paths in production
    sonalkr132 committed May 5, 2017