New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange characters in description causes gem push to blow up #275

Closed
qrush opened this Issue Mar 18, 2011 · 5 comments

Comments

Projects
None yet
4 participants
@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Jun 19, 2011

\x19 seems like the apostrophe character, which might got converted from some of the IDE. I'm trying to fix this but I can't make this test fail in Cucumber:

    Scenario: User pushes gem with bad description
      Given I am signed up and confirmed as "email@person.com/password"
      And I have a gem "PGem" with version "1.0.0" and summary "There\x91s nothing."
      And I have an api key for "email@person.com/password"
      When I push the gem "PGem-1.0.0.gem" with my api key
      And I visit the gem page for "PGem"
      Then I should see "PGem"
      And I should see "1.0.0"
      And I should see "There\x91s nothing."

sikachu commented Jun 19, 2011

\x19 seems like the apostrophe character, which might got converted from some of the IDE. I'm trying to fix this but I can't make this test fail in Cucumber:

    Scenario: User pushes gem with bad description
      Given I am signed up and confirmed as "email@person.com/password"
      And I have a gem "PGem" with version "1.0.0" and summary "There\x91s nothing."
      And I have an api key for "email@person.com/password"
      When I push the gem "PGem-1.0.0.gem" with my api key
      And I visit the gem page for "PGem"
      Then I should see "PGem"
      And I should see "1.0.0"
      And I should see "There\x91s nothing."
@darkhelmet

This comment has been minimized.

Show comment
Hide comment
@darkhelmet

darkhelmet Nov 4, 2012

Contributor

It's to happen like this: And I have a gem "PGem" with version "1.0.0" and a bogus summary

Given /^I have a gem "([^\"]*)" with version "([^\"]*)" and a bogus summary$/ do |name, version|
  build_gem(name, version, "There\x91s nothing.")
end
Contributor

darkhelmet commented Nov 4, 2012

It's to happen like this: And I have a gem "PGem" with version "1.0.0" and a bogus summary

Given /^I have a gem "([^\"]*)" with version "([^\"]*)" and a bogus summary$/ do |name, version|
  build_gem(name, version, "There\x91s nothing.")
end
@darkhelmet

This comment has been minimized.

Show comment
Hide comment
@darkhelmet

darkhelmet Nov 4, 2012

Contributor

And that blows up psych it seems:

psych exploding

That's actually not even on the POST though, that's just trying to build the gem.

Contributor

darkhelmet commented Nov 4, 2012

And that blows up psych it seems:

psych exploding

That's actually not even on the POST though, that's just trying to build the gem.

@darkhelmet

This comment has been minimized.

Show comment
Hide comment
@darkhelmet

darkhelmet Nov 4, 2012

Contributor

That stack trace is kind of useless too. It actually blows up in rubygems in builder.rb trying to dump to yaml:

rubygems exploding

Contributor

darkhelmet commented Nov 4, 2012

That stack trace is kind of useless too. It actually blows up in rubygems in builder.rb trying to dump to yaml:

rubygems exploding

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 5, 2012

Contributor

Closing.

Contributor

cmeiklejohn commented Nov 5, 2012

Closing.

@cmeiklejohn cmeiklejohn closed this Nov 5, 2012

arthurnn pushed a commit that referenced this issue Jan 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment