Strange characters in description causes gem push to blow up #275

Closed
qrush opened this Issue Mar 18, 2011 · 5 comments

4 participants

@sikachu

\x19 seems like the apostrophe character, which might got converted from some of the IDE. I'm trying to fix this but I can't make this test fail in Cucumber:

    Scenario: User pushes gem with bad description
      Given I am signed up and confirmed as "email@person.com/password"
      And I have a gem "PGem" with version "1.0.0" and summary "There\x91s nothing."
      And I have an api key for "email@person.com/password"
      When I push the gem "PGem-1.0.0.gem" with my api key
      And I visit the gem page for "PGem"
      Then I should see "PGem"
      And I should see "1.0.0"
      And I should see "There\x91s nothing."
@darkhelmet

It's to happen like this: And I have a gem "PGem" with version "1.0.0" and a bogus summary

Given /^I have a gem "([^\"]*)" with version "([^\"]*)" and a bogus summary$/ do |name, version|
  build_gem(name, version, "There\x91s nothing.")
end
@darkhelmet

And that blows up psych it seems:

psych exploding

That's actually not even on the POST though, that's just trying to build the gem.

@darkhelmet

That stack trace is kind of useless too. It actually blows up in rubygems in builder.rb trying to dump to yaml:

rubygems exploding

@darkhelmet darkhelmet added a commit that referenced this issue Nov 4, 2012
@darkhelmet darkhelmet Add test for bad characters in description/summary. Case #275
Had to build a broken gem by hand.
7f777bd
@cmeiklejohn

Closing.

@cmeiklejohn cmeiklejohn closed this Nov 5, 2012
@arthurnn arthurnn pushed a commit that referenced this issue Jan 29, 2015
@darkhelmet darkhelmet Add test for bad characters in description/summary. Case #275
Had to build a broken gem by hand.
7df6740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment