Upgrade clearance to the latest version #315

Closed
sferik opened this Issue Jul 17, 2011 · 7 comments

Comments

Projects
None yet
3 participants
Member

sferik commented Jul 17, 2011

I attempted to do this upgrade but had to back it out since I'm not very familiar with clearance and what's changed between 0.9 and 0.12.

qrush was assigned Jul 17, 2011

@sferik sferik added a commit that referenced this issue Jul 18, 2011

@sferik sferik Prepare files in advance of Rails 3.1 update
Update cannot be completed until #315 is resolved, since clearance 0.9
depends on rails 3.0.
29d8e19

sferik was assigned Sep 7, 2011

Member

sferik commented Sep 9, 2011

I spent an hour with @croaky working on this. You can see our progress is in the update_clearance branch.

Member

sferik commented Sep 14, 2011

@cmeiklejohn Nice work getting all the unit and functional tests passing.

I just rebased the update_clearance branch from master.

Contributor

cmeiklejohn commented Sep 17, 2011

All of the tests are passing except one set: email reset. This code has already been partially removed in the branch by @sferik as it was based on the deprecated clearance email confirmation functionality. Should I just modify this feature to change the email in place without sending any email?

Member

sferik commented Sep 17, 2011

W00t!

As I understand it, clearance doesn't do email confirmation anymore, for reasons explained in this article: http://robots.thoughtbot.com/post/5545254885/confirmation-bias

If we still think it's important to send confirmation email, we could roll our own, but I'm not sure that's necessary? What do you think @qrush?

Contributor

cmeiklejohn commented Sep 17, 2011

I've killed the confirmation for now since it relied on clearance code that's gone. I've committed that change so all tests are passing now. If we want to add it back, we can roll our own confirmations controller.

Contributor

cmeiklejohn commented Sep 17, 2011

Tracking in pull #350.

Member

sferik commented Sep 18, 2011

DEPLOYED!

sferik closed this Sep 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment