Subscribing is broken #397

Closed
yfeldblum opened this Issue Jan 31, 2012 · 16 comments

Comments

Projects
None yet
5 participants

Clicking the "subscribe" link for any gem gets you a 404.

Contributor

cmeiklejohn commented Jan 31, 2012

all.js is returning a 403 forbidden, probably related.

Member

sferik commented Jan 31, 2012

We should fix the all.js problem, however I'd be in favor of removing the Subscribing feature altogether now that services like Gemnasium exist. @qrush What do you think?

Member

sferik commented Jan 31, 2012

Also, it appears as though we don't have any tests for adding subscriptions. If we do end up adding back this functionality, we should make sure there are tests for it so it doesn't break again.

Contributor

cmeiklejohn commented Jan 31, 2012

Weird, we used to have a cucumber scenario for it.

Contributor

cmeiklejohn commented Jan 31, 2012

Oh wait, nevermind, I'm thinking of the functional test, which does assert that javascript is returned, but not that it is executed in the front-end.

Owner

qrush commented Jan 31, 2012

I'd like to get some stats first to see how many RSS subscribers we have and warn them to move over for at least 1-3 months before just shutting it off.

Owner

qrush commented Jan 31, 2012

Can you just try deploying again? all.css is there...seems like all.js is just messed up.

Contributor

cmeiklejohn commented Jan 31, 2012

Ah, let's do a test of staging first since that's got some changes that haven't made it to production yet. On it now.

Contributor

cmeiklejohn commented Jan 31, 2012

OK, looks like everything was already on both staging/production; anyway, I tested gem pushing, etc again on staging and it looks good. Has anything changed in the deployment process or is a cap production deploy all I need to do here?

Contributor

cmeiklejohn commented Jan 31, 2012

Subscribe works after deploy for me.

Contributor

cmeiklejohn commented Jan 31, 2012

Closing.

sferik reopened this Jan 31, 2012

Member

sferik commented Jan 31, 2012

Reopening. This issue surfaced the fact that this feature needs tests. Let's keep this issue open until those tests are committed.

I'd like to keep it.

It's an easy push-style notification for gem users (yes, the feed reader pulls, but the feed reader reader uses it like a push) that a new gem version is available. Very convenient.

Member

sferik commented Jan 31, 2012

I'm fine with keeping the feature as long as:

  1. it's working
  2. there are proper specs

It's impossible to ensure 1 without 2, so we need both, IMHO.

Contributor

postmodern commented Mar 12, 2012

Interesting that the 404 page does not show the logged-in toolbar.

Owner

qrush commented Nov 28, 2014

Looks like this is happy now. 🔫

qrush closed this Nov 28, 2014

@sonalkr132 sonalkr132 added a commit that referenced this issue Dec 19, 2016

@sonalkr132 sonalkr132 Update rdoc from 4.2.2 to 5.0.0
5.0.0 / 2016-11-05

Major enhancements

Cleanup deprecated code targeted Ruby 1.8

Bug fixes
Ensure badge data is included in result of JsonIndex template.
Ensure items in the nil section are displayed in HTML output. Issue #399 by Daniel Svensson.
Parse rb_intern_const correctly in C. PR #381 by Sho Hashimoto.
Fix broken assets caused by #335 when serving ri. PR #360 by Alex Wood.
Don't try to parse svg files. Issue #350 by Sigurd Svela.

Minor enhancements

Improve class name expansion/resolution in ri. PR #400 by NARUSE, Yui
Improve performance of document generation. PR #397 by Yusuke Endoh.

4.3.0 / 2016-11-04

Minor enhancements
Removed json dependency for Ruby 2.4.0

End to support Ruby 1.8.x
630682c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment