New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block gems that are yanked from being queried through the API #406

Closed
qrush opened this Issue Mar 7, 2012 · 4 comments

Comments

Projects
None yet
4 participants
@qrush
Member

qrush commented Mar 7, 2012

versions#show is a big one, I'm sure there's a few holes here.

@smoak

This comment has been minimized.

Show comment
Hide comment
@smoak

smoak Apr 23, 2012

Contributor

What would this entail? Just returning 404 if the gem is yanked?

Contributor

smoak commented Apr 23, 2012

What would this entail? Just returning 404 if the gem is yanked?

@qrush

This comment has been minimized.

Show comment
Hide comment
@qrush

qrush Apr 24, 2012

Member

Yep! That should be enough... Make sure to check all of the endpoints :)

Sent from my iPhone

On Apr 23, 2012, at 6:40 PM, Scott Moak
reply@reply.github.com
wrote:

What would this entail? Just returning 404 if the gem is yanked?


Reply to this email directly or view it on GitHub:
#406 (comment)

Member

qrush commented Apr 24, 2012

Yep! That should be enough... Make sure to check all of the endpoints :)

Sent from my iPhone

On Apr 23, 2012, at 6:40 PM, Scott Moak
reply@reply.github.com
wrote:

What would this entail? Just returning 404 if the gem is yanked?


Reply to this email directly or view it on GitHub:
#406 (comment)

@adkron

This comment has been minimized.

Show comment
Hide comment
@adkron

adkron Nov 4, 2012

Contributor

This should be closed. The code is already merged.

Contributor

adkron commented Nov 4, 2012

This should be closed. The code is already merged.

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn Nov 4, 2012

Contributor

🍻 🍺 🍻

Contributor

cmeiklejohn commented Nov 4, 2012

🍻 🍺 🍻

@cmeiklejohn cmeiklejohn closed this Nov 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment