RFE: Support for conditional GET / If-Modified-Since header #436

Closed
atodorov opened this Issue Jun 28, 2012 · 3 comments

Comments

Projects
None yet
4 participants

I have an application which does send lots of GET requests to your website.

To minimize network load and bandwidth usage I'm sending If-Modified-Since header with every request. Unfortunately the API doesn't seem to support that (or it be configured at present). Please fix it.

I'm using the JSON interface, .e.g. GET http://rubygems.org/api/v1/versions/PACKAGE.json

qrush added the health label Nov 28, 2014

Owner

qrush commented Nov 28, 2014

We should definitely have some stale? checks in the API.

qrush added the api label Nov 28, 2014

arthurnn self-assigned this Jan 20, 2015

Member

arthurnn commented Jan 20, 2015

Yes, we should add more stale? checks on our API, however the versions API already have that check https://github.com/rubygems/rubygems.org/blob/master/app/controllers/api/v1/versions_controller.rb#L10-L12 .
And seems like it is working for me:

curl -i https://rubygems.org/api/v1/versions/rails.json --header 'If-None-Match: "944a74b63f8cfdf4ec5d9521ed003ba0"'
Owner

dwradcliffe commented Mar 25, 2016

This is working for me too. Closing since it is stale. (pun intended)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment