New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use each for link_to_page on rubygems#show #1014

Merged
merged 1 commit into from Jul 14, 2015

Conversation

Projects
None yet
4 participants
@spk
Contributor

spk commented Jul 13, 2015

No description provided.

qrush added a commit that referenced this pull request Jul 14, 2015

Merge pull request #1014 from spk/use-each-for-link_to_page
Use each for link_to_page on rubygems#show

@qrush qrush merged commit 13cd0c6 into rubygems:master Jul 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@qrush

This comment has been minimized.

Member

qrush commented Jul 14, 2015

👌

@spk spk deleted the spk:use-each-for-link_to_page branch Jul 14, 2015

@olivierlacan

This comment has been minimized.

Contributor

olivierlacan commented on app/views/rubygems/show.html.erb in 1309369 Nov 8, 2015

Why re-encode the Linkset link types here when we coud simply call Linkset::LINKS.each?

I understand that there might be a specific order required in the view but couldn't we safely update the order stored in the LINKS constant instead? Or does the order matter in some other location?

This comment has been minimized.

Contributor

spk replied Nov 8, 2015

I only wanted to remove this duplication on the template. I did not know about Linkset::LINKS.

This comment has been minimized.

Contributor

olivierlacan replied Nov 8, 2015

Cool, I guess I'll just submit a PR for this then. :-)

This comment has been minimized.

This comment has been minimized.

Contributor

kbrock replied Nov 9, 2015

That PR is kinda stalled, maybe I should create a separate PR with just that change. I agree. Very cool stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment