Remove unreachable code #1319
Merged
Remove unreachable code #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods regarding Redis were removed in 9207533; however, Rubygem.versions_key was not.
The code surrounding Version#to_index usage was in 232dcf6.
The majority of code using Version.with_deps revolved around Redis, which was removed in 9207533.
…_when All tests using this method switched to an alternate way to assert correct behavior in b235aeb.
|
thanks |
|
👍 🔪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
I've been fascinated by identifying and removing dead code and unreachable code, so I built a tool called "unused" (https://github.com/joshuaclayton/unused) and ran it on the codebase.
This is a PR removing discrete chunks of unreachable code, with context in each commit around when the surrounding code using it was changed.