Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rails 5.2 #1771
I have been able get it down to a single test failure:
But I don't know why there aren't any full stack traces available for the test.
Stepping through the code, I found out that there is a scrub_env! call on the request.
Conclusion: Looks like rails 5.2.1 broke backwards compatibility: rails/rails#32673
referenced this pull request
Aug 24, 2018
I opened an issue to track the default configuration migration. I decided not to complete that in this pull request after discovering that the previous rails 5.0 & 5.1 migrations didn't migrate to those default configurations. I think the default configurations should be completed in order, starting with 5.0 and moving forward.
I think I'm ready for someone to do a review.
I'm on the Bundler team, not the Rubygems team, but this looks pretty reasonable to me.
One requirement before merging will be to disable encrypted cookies (without which we wouldn't be able to roll back). See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-1-to-rails-5-2 for details.
Encrypted cookies are disabled by default. This is why the line to add them in is commented out in the new rails configuration file. https://github.com/rubygems/rubygems.org/pull/1771/files#diff-0b94a9ee8eb607505aa56304e7a6f626R20
The path to migration for new config options is documented in this issue: #1773