New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to confirmation email #1888

Merged
merged 1 commit into from Jan 18, 2019

Conversation

3 participants
@sonalkr132
Copy link
Member

sonalkr132 commented Jan 14, 2019

Text emails are landing in spam for some providers (office 365), this should fix that.
Template taken from https://github.com/sendwithus/templates
(goldstart/progress.html)

Closes: #1523

Screenshot:
screenshot from 2019-01-14 20-08-38

I am not so sure if premailer is working as expected, will test on staging. Also, goes without saying.. email template could be modular and we do need to update template of email update as well, will take them on in future PRs.

[1] existing mail report: https://spam-check.glockapps.com/test/st-3-7bfxpzzcs0
[2] template report: https://spam-check.glockapps.com/test/st-3-7cat0n02i7

@sonalkr132

This comment has been minimized.

Copy link
Member Author

sonalkr132 commented Jan 14, 2019

@sonalkr132 sonalkr132 force-pushed the sonalkr132:email-style branch 2 times, most recently from bff405e to b65bdf5 Jan 14, 2019

Add style to confirmation email
Text emails are landing in spam for some providers (office 365), this should fix that.
Template taken from https://github.com/sendwithus/templates
(goldstart/progress.html)

@sonalkr132 sonalkr132 force-pushed the sonalkr132:email-style branch from b65bdf5 to 70d9369 Jan 15, 2019

@sonalkr132 sonalkr132 merged commit 6ead865 into rubygems:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sonalkr132 sonalkr132 deleted the sonalkr132:email-style branch Jan 18, 2019

@dwradcliffe dwradcliffe deployed to production Feb 1, 2019 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment