Remove api key rubygems_id from form url query string #3085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #2944 on staging, @sonalkr132 found that
api_key[rubygem_id]
was added as a query param on new and edit pages.It's coming from the hidden
rubygems_id
input js (used when the original rubygems selector is disabled).Solution
HTML forms with
method: POST
should not include query strings for each input. It seems like this hidden input wasn't included in this clause (thought it was for GET request?). When I added the hidden input to therubygem_id
form group div, the query string doesn't get included anymore.I updated tests to make that this doesn't happen again, let me know if it's overkill.