Add "gem" to reserve gem names list. #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the effect of refusing to allow uploads of this gem and showing the gem as reserved when loading the gem page.
segiddins
approved these changes
Mar 10, 2023
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 188 188
Lines 4548 4548
=======================================
Hits 4446 4446
Misses 102 102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the effect of refusing to allow uploads of this gem and showing the gem as reserved when loading the gem page (screenshot).
I don't think it blocks downloading the existing gem, however. If we want to yank it after this is deployed, that could resolve any confusion that could be caused by this gem, especially with the
gem exec gembehavior added in rubygems 3.4.8.