Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Webhooks for yanked gems #366

Closed
wants to merge 1,853 commits into from
@laserlemon
Collaborator

Yanking gems is a necessary evil.

I don't think there's any good way to prevent authors from prematurely pushing broken or unfinished gems. Unfortunately, yanked gems often leave people's projects in gem dependency limbo. For instance, the good people of @collectiveidea have found their projects depending upon the gherkin gem (indirectly through cucumber) and the surrounding dependencies are such that gherkin is locked down to ~> 2.3.8. The problem is that the only versions that satisfy that requirement are 2.3.8, 2.3.9 and 2.3.10, all of which have been yanked.

http://rubygems.org/gems/gherkin/versions

While scenarios like the one above can't always be avoided, it's important to notify developers when a version is yanked so they can take appropriate actions and I think that the existing web hook functionality is a great way to deliver those notifications.

In my mind, the easiest way to pull it off is to hit the same registered web hook URLs rather than registering separate hooks for yanks. So if we were to hit the same URLs, either the method or the payload would have to change in order to differentiate pushes and yanks. I was in favor of an identical DELETE request until I started getting mixed signals on whether DELETE requests can/should have request bodies.

If we were to change the web hook payload, I think the existing webhook bodies should stay the same and the new hooks should take on a backwards-incompatible form so that yanked gem versions aren't mistaken for newly pushed gem versions with existing web hook subscribers.

What are your feelings on the concept of yank web hooks and their implementation?

sferik and others added some commits
@sferik sferik Update gravtastic dependency to version 3.2.6 cd4ca6b
@sferik sferik Update rdoc dependency to version 3.9.4 cfe1943
@sferik sferik Update webmock dependency to version 1.7.6 365364c
@sferik sferik Update capybara dependency to version 1.1.1 0c01aaa
@cmeiklejohn cmeiklejohn Add a migration to drop some unused columns [#333] 0a77910
@cldwalker cldwalker add tests for dependencies api endpoint 185fd65
@sferik sferik Update gherkin dependency to 2.4.18, mostly just to force a Travis build
This should be a low-risk development dependency update.
0433ff4
@sferik sferik Don't test against Ruby 1.9.2 7ac18b1
@sferik sferik Update excon dependency to version 0.6.6 2d1a285
@sferik sferik Update high_voltage dependency to version 1.0.1 9ba3150
@sferik sferik Update newrelic_rpm dependency to version 3.1.2 884ee11
@sferik sferik Update method_source dependency to version 0.6.5 bb29c6c
@sferik sferik Update ruby_parser dependency to version 2.3.0 d7482d0
@sferik sferik Update pry dependency to version 0.9.5 28cc48a
@sferik sferik Update cucumber_rails dependency to version 1.0.3 bb8f7e5
@sferik sferik Manually start Redis before running tests on Travis e3e0254
@sferik sferik Revert "Manually start Redis before running tests on Travis"
This reverts commit 2146357.
34f68cd
@sferik sferik Update cucumber dependency to version 1.0.6
Progress against issue #345
37b1391
@sferik sferik Downgrade cucumber-rails dependency to version 1.0.2
Fixes #345
af313a0
@nickrivadeneira nickrivadeneira get rid of the rubygems.org gemset, this is silly 311c047
@nickrivadeneira nickrivadeneira use factory_girl 2.0 DSL for parent factories 1a677e0
@nickrivadeneira nickrivadeneira set the yamler to psych in initializer too a8b1238
@nickrivadeneira nickrivadeneira apparently I am inept at factory girl 20b321e
@sferik sferik Update cucumber-rails dependency to version 1.0.5.
Making an exception to the mid-week update policy in order to resolve
the YAML::Syck::DefaultKey issue.
b1ca7ed
@sferik sferik Update clearance dependency to version 0.12.0 d71e74a
@sferik sferik Remove confirmed_password d449ab1
@sferik sferik Replace Factory(:email_confirmed_user) with Factory(:user)
See f2f3a1e9ec4a72b7164f90038531dbfd17200b91.
45cad6e
@sferik sferik Generate new clearance features be47da8
@sferik sferik Remove confirmations controller 35a94b9
@sferik sferik Make unit tests pass with new clearance version 730023c
@cmeiklejohn cmeiklejohn Require clearance/testing instead of clearance/shoulda_macros. c827f1c
@cmeiklejohn cmeiklejohn There is no more email confirmed. 1b8cff6
@cmeiklejohn cmeiklejohn No longer test for confirmed users. 9af25c6
@cmeiklejohn cmeiklejohn No longer confirm email. e728b11
@cmeiklejohn cmeiklejohn No longer email_confirmed? 17147fe
@cmeiklejohn cmeiklejohn Update features with new clearance syntax. baab17b
@cmeiklejohn cmeiklejohn Update clearance syntax. 573b260
@cmeiklejohn cmeiklejohn Update clearance step to assign current user to @me. ad3efb8
@cmeiklejohn cmeiklejohn Fix missed syntax change. aafa9f8
@cmeiklejohn cmeiklejohn There is no longer a flash success after create in clearance. dc31622
@cmeiklejohn cmeiklejohn No longer a flash message on successful sign-in. bedf403
@cmeiklejohn cmeiklejohn We no longer have email confirmed users. 0d6d187
@cmeiklejohn cmeiklejohn One error message on too-long, but well-formed email; no confirmation…
… after signup.
aeb2ad4
@smoak smoak Adding api support for most downloaded of all time. 66808fb
@smoak smoak Added unit tests for changes to Download 51a5c4b
@michaelfairley michaelfairley Have api/v1/gems/just_updated return gems rather than versions 2c32cb3
@cmeiklejohn cmeiklejohn Don't require that the sign in and sign out links be in title case. deb89c7
@cmeiklejohn cmeiklejohn Only one error message here. f496719
@cmeiklejohn cmeiklejohn Fix some more testing against case insensitive links. 3f7fa84
@cmeiklejohn cmeiklejohn Fix form localization. 479c88c
@cmeiklejohn cmeiklejohn DOn't require that the sign in check be on a particular page. c6ce824
@cmeiklejohn cmeiklejohn Add guard. 0aa624c
@cmeiklejohn cmeiklejohn Add guard-bundler. f4edaad
@cmeiklejohn cmeiklejohn The app has a capybara dependency for testing through the clearance f…
…eatures.
5802231
@cmeiklejohn cmeiklejohn Hard code the steps of singing in with a new password, since we only …
…ever do it once in all of the scenarios.
c87a663
@cmeiklejohn cmeiklejohn Remove session is cleared code. d878678
@cmeiklejohn cmeiklejohn Fix selector syntax issue in the clearance steps. b9362ac
@cmeiklejohn cmeiklejohn Downcase the email in the override, as stock clearance would. 0219bf0
@cmeiklejohn cmeiklejohn Update stock clearance matcher for email field to match our email or …
…username fields.
8d235e2
@cmeiklejohn cmeiklejohn Add home page path. ac6e31b
@cmeiklejohn cmeiklejohn Update input fields to be of email type. 382183a
@cmeiklejohn cmeiklejohn Kill double coverage scenario since we've already got it in handle/si…
…gn_in.
c504711
@cmeiklejohn cmeiklejohn Update form fields to use the email_field type instead of text_field. 08daa19
@sferik sferik Merge pull request #347 from smoak/most_downloaded_all_time_api
Adding api support for most downloaded of all time.
465c358
@cmeiklejohn cmeiklejohn Merge pull request #348 from michaelfairley/fix_just_updated
Have api/v1/gems/just_updated return gems rather than versions.
d838e50
@cmeiklejohn cmeiklejohn Rename the reset to change since there is no longer a confirmation. K…
…ill confirmation code.
edaca25
@cmeiklejohn cmeiklejohn Update form to have an email-type field instead of a plain text field. 2432708
@sferik sferik Merge pull request #350 from rubygems/update_clearance
Update clearance.
dec76ed
@sferik sferik Remove trailing whitespace d6153c6
@cmeiklejohn cmeiklejohn Login field needs to allow email or handle. 5a5139d
@sferik sferik Update gherkin dependency to version 2.4.21 585f943
@sferik sferik Update rack dependency to version 1.2.4 0660a43
@sferik sferik Update will_paginate dependency to version 3.0.1 09d15bc
@sferik sferik Update crack dependency to version 0.3.0 0e4e245
@sferik sferik Update yajl-ruby dependency to version 1.0.0 7e30ee3
@cmeiklejohn cmeiklejohn Merge pull request #305 from nz/rubygems_session
Change the session cookie to be accessible from all subdomains and HTTPS.
ab2f1b5
@sferik sferik Remove code traces of ownership.approved 1e534f9
@sferik sferik We shouldn't need to import gems from RubyForge ever again a3f0822
@cmeiklejohn cmeiklejohn Merge pull request #344 from cmeiklejohn/333_drop_unused_database_col…
…umns

Add a migration to drop some unused columns and tables [#333]
4843333
@cmeiklejohn cmeiklejohn Fix a couple places where we didn't kill approved. 9725969
@sferik sferik Update json_pure dependency to version 1.6.1 420d556
@sferik sferik Update json dependency to version 1.6.1 2113a14
@sferik sferik Update paul_revere dependency to version 0.2.1 e76abe0
@evanphx evanphx Prune out Syck DefaultKey noise 1c9e325
@cmeiklejohn cmeiklejohn Change to gsub in case there are multiple YAML/Syck parse failures. f73515c
@cmeiklejohn cmeiklejohn Test coverage for dependency changes for mitigating parse errors. 2b153e4
@cmeiklejohn cmeiklejohn Add migration to clean up malformed requirements fields from yaml/syc…
…k issues.
be0e016
@cmeiklejohn cmeiklejohn Merge pull request #331 from cmeiklejohn/syck_issues_gh_298
Mitigate Syck/DefaultKey Noise.
7a3b4ea
@nickrivadeneira nickrivadeneira use jquery-rails and hope it works cfb3af8
@nickrivadeneira nickrivadeneira use the right rails application config variable, wtf b894f8d
@nickrivadeneira nickrivadeneira put actionmailer config where it belongs a79c4f4
@cmeiklejohn cmeiklejohn Maintenance mode doesn't load A/R, so you can't rely on models being …
…there. Extract patterns into their own module. close #355.
a1f8e3a
@cmeiklejohn cmeiklejohn Don't autoload, but require instead. 03047cb
@cmeiklejohn cmeiklejohn show an all versions link if there's yanked versions. closes #354 b09a8b3
@sferik sferik Update crack dependency to version 0.3.1 0131a00
@sferik sferik Update coderay dependency to version 1.0.0 aec4112
@sferik sferik Update factory_girl dependency to version 2.1.2 610c5c6
@sferik sferik Update pry dependency to version 0.9.6 a17709e
@sferik sferik Update selenium-webdriver dependency to version 2.7.0 875ba2c
@sferik sferik Update cucumber-rails dependency to version 1.0.6 8bdc62b
@bryckbost bryckbost Update delayed_job dependency to version 3.0.0.pre.
Add delayed_job_active_record dependency needed for DJ 3.0.0.pre.
5768bfd
@bryckbost bryckbost Remove pysch dependency. eecb5df
@laserlemon laserlemon Ensure that nested ActiveRecord objects are properly encoded as YAML c646732
@sferik sferik Merge pull request #356 from rubygems/psych
DelayedJob upgrade and Psych fixes
4cd56f7
@sferik sferik Revert "Don't test against Ruby 1.9.2"
This reverts commit 646db52.
c328a61
@sferik sferik Update pry dependency to version 0.9.6.2 9535083
@sferik sferik Update will_paginate dependency to version 3.0.2 2326fd7
@sferik sferik Update guard-cucumber dependency to version 0.7.1 0d37c1c
@sferik sferik Update tzinfo dependency to version 0.3.30 17a203a
@sferik sferik Update sinatra dependency to version 1.2.7 e7c63f3
@sferik sferik Update fog dependency to version 1.0.0 b6f93e3
@sferik sferik Update cucumber-rails dependency to version 1.1.0 a324f73
@sferik sferik Update guard-cucumber dependency to version 0.7.2 fac99d5
@sferik sferik Update method_source dependency to version 0.6.6 fb5dc80
@sferik sferik Update cucumber-rails dependency to version 1.1.1 91c81c9
@sferik sferik Update guard dependency to version 0.8.4 ce9959a
@sferik sferik Test against Ruby 1.9.3 3c5cceb
@sferik sferik Apparently, Ruby 1.9.3 doesn't like chained rake tasks 47d0572
@sferik sferik Revert "Apparently, Ruby 1.9.3 doesn't like chained rake tasks"
This reverts commit 304657f.
645efc5
@sferik sferik Revert "Test against Ruby 1.9.3"
This reverts commit eaa831e.
6de8199
@sferik sferik Cleanup whitespace 63f2847
@sferik sferik Ignore hash key order 2b47a44
@sferik sferik Test against Rubinius db7f511
@nickrivadeneira nickrivadeneira link to guides not docs site on the homepage 4985fa8
@nickrivadeneira nickrivadeneira change guides copy too 73c37d5
@nickrivadeneira nickrivadeneira chmod a-x on Rakefile, how did that ever happen ce1033b
@nickrivadeneira nickrivadeneira finally solve the Internal Server Error mystery! 7b3dd4f
@sferik sferik Update excon dependency to version 0.7.6 9a5c7dd
@sferik sferik Update selenium-webdriver dependency to version 2.8.0 694c00c
@sferik sferik Remove duplicate find_rubygems methods b1ef9a3
@sferik sferik Don't require authentication to find gems by owner
Closes #359.
5c4ce1e
@sferik sferik Update rdoc dependency to version 3.10 820a7d4
@brianmario brianmario remove calls to the JSON gem API 865bcf6
@sferik sferik Update example database configuration to work on Mac OS X 10.7 (Lion) 72a1a70
@sferik sferik Parse JSON with multi_json instead of specifying a particular JSON in…
…terface

See also #362.
c9d2458
@sferik sferik Add explicit mutli_json dependency 53d4b52
@sferik sferik Update gherkin dependency to version 2.5.2 2a340de
@sferik sferik Update guard-cucumber dependency to version 0.7.3 07bfa63
@sferik sferik Update newrelic_rpm dependency to version 3.2.0 6dd5d9b
@sferik sferik Update jquery-rails dependency to version 1.0.16 4f1c738
@sferik sferik Update term-ansicolor dependency to version 1.0.7 27567f6
@sferik sferik Update xml-simple dependency to version 1.1.1 cad46b9
@sferik sferik Update clearance dependency to version 0.13.0 a645ac0
@sferik sferik Update webmock dependency to version 1.7.7 e1d9ede
@sferik sferik Update factory_girl_rails dependency to version 1.3.0 b2e14d7
@sferik sferik Update gherkin dependency to version 2.5.4 1694d16
@sferik sferik Update guard dependency to version 0.8.8 0e14e86
@sferik sferik Update rdoc dependency to version 3.11 53d6f2c
@sferik sferik Update selenium-webdriver dependency to version 2.9.1 78c7dcb
@sferik sferik Update rake dependency to version 0.9.2.2 5d925c9
@sferik sferik Update mime-types dependency to version 1.17.1 d1f4d20
@nickrivadeneira nickrivadeneira revamp footer, add gauges and newrelic c6c2d87
@nickrivadeneira nickrivadeneira add gauges tracking code 97cca10
@nickrivadeneira nickrivadeneira absolute positioning sucks e143c3e
@nickrivadeneira nickrivadeneira add link to m.rubygems.org, reorganize minor footer links edb2220
@sferik sferik Update pry dependency to version 0.9.7.3 d323d92
@sferik sferik Update mime-types dependency to version 1.17.2 2bf0c69
@sferik sferik Update selenium-webdriver dependency to version 2.10.0 892c58e
@sferik sferik Update cucumber dependency to version 1.1.1 51ac310
@sferik sferik Test against Rubinius in both Ruby 1.8 and 1.9 mode 2f08203
@sferik sferik This is redundant 35a28a3
@sferik sferik Revert "This is redundant"
This reverts commit a66a3ba.
18d5afd
@sferik sferik Revert "Test against Rubinius in both Ruby 1.8 and 1.9 mode"
This reverts commit a7cd4c2.
28bcf9b
@sferik sferik Update polyglot dependency to version 0.3.3 5f944f7
@sferik sferik Update cucumber-rails dependency to version 1.2.0 0fc2e83
@sferik sferik Update gherkin dependency to version 2.6.2 026e5a2
@sferik sferik Update newrelic_rpm dependency to version 3.2.0.1 3be6515
@sferik sferik Update pry dependency to version 0.9.7.4 471f839
@sferik sferik Update tzinfo dependency to version 0.3.31 66dc01a
@sferik sferik Update newrelic_rpm dependency to version 3.3.0 e3a0d2e
@qrush qrush bump to RG 1.8.11 a51893c
@sferik sferik Update gherkin dependency to version 2.6.3 4857f7b
@sferik sferik Update cucumber dependency to version 1.1.2 533555d
@sferik sferik Update guard-cucumber dependency to version 0.7.4 901719e
@sferik sferik Update selenium-webdriver dependency to version 2.12.1 92377ff
@sferik sferik Update jquery-rails dependency to version 1.0.16 efa5d89
@sferik sferik Update yajl dependency to version 1.1.0 3ad9f70
@sferik sferik Update fog dependency to version 1.1.0 1e863aa
@sferik sferik Update fog dependency to version 1.1.1 8693a8e
@sferik sferik Update gherkin dependency to version 2.6.4 4b1e73a
@sferik sferik Update database_cleaner dependency to version 0.7.0 84cf849
@sferik sferik Update selenium-webdriver dependency to version 2.12.2 de43657
@sferik sferik Update ffi dependency to version 1.0.11 c891ad1
@sferik sferik Update rails dependency to version 3.0.11 7ca9f27
@sferik sferik Update factory_girl_rails dependency to version 1.4.0 ff3d70f
@sferik sferik Update jquery-rails dependency to version 1.0.18 c6578f9
@sferik sferik Update selenium-webdriver dependency to version 2.13.0 e69ce1a
@sferik sferik Update sexp_processor dependency to version 3.0.8 de4b44d
@sferik sferik Update capybara dependency to version 1.1.2 94f4ae8
@sferik sferik Update gherkin dependency to version 2.6.6 5f036f0
@qrush qrush stop cucumber from complaining, load psych first for 1.9.3 132d285
@qrush qrush don't bother with 1.8.7 or 1.9.2, use 1.9.3 for travis 524f271
@sferik sferik Update webmock dependency to version 1.7.8 e07ea6b
@qrush
Owner

yes yes, this could be v2 of the webhooks api. @nz needs it for search.rubygems.org to work. basically there could be different POST bodies, something like:

{action:'yank', rubygem: {name: 'gherkin', ...}

Thoughts on this?

@laserlemon
Collaborator

Yes, I like the {"event": …, "payload": …} structure. I like payload since webhooks could eventually extend past just events on rubygems. The initial events could be push, yank and I don't see why we'd exclude unyank.

And while it might be a little wonky, this could be rolled out in a backwards-compatible-ish way by including the new event and payload keys/values alongside the current webhook payload, but only during the webhooks v1 deprecation.

@laserlemon
Collaborator

This is backwards-compatible with existing webhooks. I am a bit concerned about the authorization header though, because it doesn't take into account the event key. I can't think of a way to make a backwards-compatible change to the authorization header to include the event. With v2 of webhooks, I think that the authorization header could change simply to the SHA2 or MD5 hash of the raw JSON + the user's API key, rather than parsing out particular values from the JSON.

sferik and others added some commits
@sferik sferik Update cucumber dependency to version 1.1.3 191897e
@sferik sferik Update factory_girl dependency to version 2.3.1 62407db
@qrush qrush default to 1.9.3-p0 for rvm/rbenv f006f87
@qrush qrush retrust rvmrc for staging a28e09b
@qrush qrush hook up rvm cap integration, stop hardcoding REE for bluepill b153d46
@qrush qrush attempt to make bluepill happy with running as non-root 8867efd
@qrush qrush it helps to actually run commands 5164db6
@qrush qrush check memory usage, maybe that will force bluepill to monitor 5d69d62
@qrush qrush use rake jobs:work instead of script/delayed_job 18c4f91
@qrush qrush set yamler to syck until this YAML nonsense with psych is figured out ccfcfd7
@sferik sferik Update excon dependency to version 0.7.8 edf573b
@qrush qrush move indexer to its own class, kill vault 6a48bcb
@qrush qrush move WebHookJob into jobs/ as Notifier 5bf890c
@qrush qrush stick with syck 4ccd845
@sferik sferik Update jquery-rails dependency to version 1.0.19 3dbd9c9
@sferik sferik Update rubyzip dependency to version 0.9.5 52ebfc3
@sferik sferik Update factory_girl dependency to version 2.3.2 5eca100
@sferik sferik Remove psych gem (not necessary in Ruby 1.9) 50d823c
@sferik sferik Update childprocess dependency to version 0.2.3 c489cf5
@sferik sferik Rubinius 2.0 is now the default Rubinius on Travis 92690c6
@sferik sferik Update json dependency to version 1.6.2 67dd4fc
@qrush qrush lets try not locking to syck ccae0bc
@sferik sferik Update multi_json dependency to version 1.0.4 ab4065f
@qrush qrush Trust rvmrc everywhere 94a2865
@qrush qrush just trust rvmrcs in /etc/rvmrc instead b8c5f9c
@sferik sferik Update selenium-webdriver dependency to version 2.14.0 cfec77f
@sferik sferik Update delayed_job dependency to version 3.0.0.pre4 fa974d3
@sferik sferik Replace validates_url_format_of with validates_formatting_of
The validates_url_format_of gem was poorly maintained. I know, because I
help maintain it. :P
30eb2ee
@sferik sferik Update excon dependency to version 0.7.9 145a030
@sferik sferik Update json dependency to version 1.6.3 023a4bd
@sferik sferik Convert to Markdown 2f8fbbe
@sferik sferik Fix broken images [ci skip] 7cc6f58
@sferik sferik Fix broken link [ci skip] bb24ef9
@sferik sferik Update validates_formatting_of dependency to version 0.3.1 630185a
@sferik sferik Run tests on 1.9.2 34c0d5e
@sferik sferik Run tests on MRI 1.9.3 d374f5e
@sferik sferik Maybe this isn't necessary? c23d0b8
@sferik sferik Add back one rake task at a time 2c6de5e
@sferik sferik Go back to only testing on 1.9.2 for now 5a82670
@sferik sferik Update validates_formatting_of dependency to version 0.3.2 717aba8
@sferik sferik Fix tests 73524a4
@sferik sferik Revert "Fix tests"
This reverts commit 44e9538.
f39d4eb
@qrush qrush bump to 1.8.12 09a9d1d
@sferik sferik Add Travis-style dependency status image [ci skip] 5729eda
@sferik sferik Update gherkin dependency to version 2.6.9 fe7f09e
@sferik sferik Make status images more consistent [ci skip] f6817db
@sferik sferik Update cucumber-rails dependency to version 1.2.1 aa50892
@sferik sferik Update excon dependency to version 0.7.10 b28a77b
@sferik sferik More Ruby version pruning bfe4a8a
@sferik sferik Update excon dependency to version 0.7.12 3c83f4c
@qrush qrush don't drop downloads into a hash, just group by 2 and roll with it db5a86f
@laserlemon laserlemon Add failing Cucumber scenarios describing desired yank/unyank webhook…
… functionality
85d617a
@laserlemon laserlemon Pass failing yank/unyank webhook scenarios 015f65b
@laserlemon laserlemon Pass failing webhook specs after yank/unyank webhook integration 3c114b8
@laserlemon laserlemon Eliminate an unnecessary query from the webhook firing process 35b656e
@laserlemon laserlemon Rename the new webhook "payload" key to "rubygem." 99d9bb0
@laserlemon laserlemon Only include the legacy webhook payload keys for the original "push" …
…event
4375195
@laserlemon
Collaborator

Rebased against master. I'm getting a few intermittent lexing errors from Gherkin but they seem unrelated since I'm getting them in master as well.

@jrochkind

Sorry if this is unwelcome, it's not about the actual feature, but instead about the use case for the feature you mention.

If Issue #123 were complete, so the reverse dependencies of a gem were known.... rubygems could even automatically identify which gems are effected (at least as a first-level dependency) by a yank, even going so far as to see (using bundler?) if those reverse dependencies are now left in a not-possible-to-resolve-dependencies state as a result of the yank... and rubygems usually knows the contact email address of those reverse dependencies too....

you see where that's going. It could actually automatically email authors of gems left in such states by yanks of their dependencies. Perhaps as an opt-in service to a rubygems.org account, to avoid being spam.

@laserlemon
Collaborator

@jrochkind That's right in line with my intention for the yank/unyank webhook. I already built an opt-in service like you mention (Gemnasium) and I'd like for it to be able to notify users of potentially unresolvable bundler states.

@gravis

Hi there, what's the status of this, please? I don't see any reason not to merge it, as yanking is a "common" operation on rubygems, it should be available in the api.
Thanks!

@gonzoyumo

Hi, any hint about possible merging date on this ? or is there anything that blocks this PR ?

thanks

@maletor

+1

@adkron
Collaborator

What is holding this up right now?

@gravis

Any news on this?
Thanks :)

@rastasheep

Any new info about this ?

@greysteil

+1 for this!

@qrush qrush removed this from the 201307 milestone
@laserlemon laserlemon removed this from the 201307 milestone
@qrush
Owner

Holy moly this is out of date. Can we get this rebased so we can get this in finally?

Also @indirect doesn't Bundler use something like this unofficially?

@davefp

@laserlemon As a result of #610 a large chunk of the repo's history was re-written. Please rebase your PR so that it will merge cleanly. Thanks!

(There are further details on the blog: http://blog.rubygems.org/2015/02/01/rewriting-history.html)

@laserlemon
Collaborator

@davefp :laughing: I can try! This pull request is over three years old :smile:, so I will but only if this is still being considered for inclusion. Thanks!

@laserlemon
Collaborator

Welp, I tried. I give up. Please feel free to reopen the issue if anybody else would like to take a shot.

@laserlemon laserlemon closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.