Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preStop lifecycle hook for nginx #3746

Merged
merged 1 commit into from Apr 28, 2023
Merged

Conversation

segiddins
Copy link
Member

Mirroring the hook we already have for the puma container

Following discussion in puma/puma#2343

YAML taken from https://blog.gruntwork.io/delaying-shutdown-to-wait-for-pod-deletion-propagation-445f779a8304

Mirroring the hook we already have for the puma container

Following discussion in puma/puma#2343

YAML taken from https://blog.gruntwork.io/delaying-shutdown-to-wait-for-pod-deletion-propagation-445f779a8304
@segiddins segiddins requested a review from indirect April 28, 2023 01:27
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #3746 (128551a) into master (d81205e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3746   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files         212      212           
  Lines        5180     5194   +14     
=======================================
+ Hits         5118     5132   +14     
  Misses         62       62           

see 5 files with indirect coverage changes

@segiddins segiddins merged commit 6372c04 into master Apr 28, 2023
11 checks passed
@segiddins segiddins deleted the segiddins/nginx-prestop branch April 28, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants