Skip to content

Loading…

Keep leaderboard representation of gems consistent. #408

Closed
wants to merge 1 commit into from

4 participants

@ravinggenius

No description provided.

@qrush
RubyGems member

I'd rather see this the other way...I hate the dash style but it's there out of laziness right now. To clarify, I'd rather see:

rails (3.0.0)

Instead of:

rails-3.0.0.

Does that make sense? Sorry for being a pain here.

@ravinggenius

While I personally prefer the dash representation, I am fine with either representation. Both gem list and bundle list use parenthesis, so let's do that. My main point was consistency. :)

What to do about the download count? rails (3.2.3) (123456789)? Two sets of parenthesis is a bit awkward. Should we wrap the download count with [] to differentiate?

@cmeiklejohn

[] works for me. Get it patched and I'll merge it! Thank you!

@pretzelmaker

It looks like this has been stripped from the homepage. Should we still address this or close?

@cmeiklejohn

Did we kill the code or just comment it out? I'd be up for just patching it (since it's really small) if the code is still there and we might reactivate it.

@qrush
RubyGems member

This is no longer relevant with the redesign.

@qrush qrush closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 10, 2012
  1. Keep leaderboard representation of gems consistent.

    Thomas Ingram committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 app/views/home/index.html.erb
View
4 app/views/home/index.html.erb
@@ -49,7 +49,7 @@
<ol>
<% @latest.each do |rubygem| %>
<li>
- <%= link_to rubygem, rubygem, :title => short_info(rubygem.versions.most_recent) %>
+ <%= link_to "#{version.rubygem.name}-#{version.number}", rubygem, :title => short_info(rubygem.versions.most_recent) %>
</li>
<% end %>
</ol>
@@ -73,7 +73,7 @@
<ol>
<% @updated.each do |version| %>
<li>
- <%= link_to version.to_title, version.rubygem, :title => short_info(version) %>
+ <%= link_to "#{version.rubygem.name}-#{version.number}", version.rubygem, :title => short_info(version) %>
</li>
<% end %>
</ol>
Something went wrong with that request. Please try again.