Add J and K to navigate between listed gems #410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as Google Reader and many other apps, use J to move the selection down, K to move the selection up and press enter to go to the page of the gem.
I would've liked to write unit tests for this, but there is nothing setup for this. Maybe time to use the asset pipeline and throw in something like Jasmine/evergreen?
PS. There is a lot of commented out code in
application.js
. What should we do with this?