Add J and K to navigate between listed gems #410

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@iain
Contributor

iain commented Mar 14, 2012

Just as Google Reader and many other apps, use J to move the selection down, K to move the selection up and press enter to go to the page of the gem.

I would've liked to write unit tests for this, but there is nothing setup for this. Maybe time to use the asset pipeline and throw in something like Jasmine/evergreen?

PS. There is a lot of commented out code in application.js. What should we do with this?

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Mar 14, 2012

Contributor

I like the jasmine idea, and you could do that regardless of the asset pipeline inclusion. We're still working on getting the rails 3.1 thing sorted so that's probably the best route.

Contributor

cmeiklejohn commented Mar 14, 2012

I like the jasmine idea, and you could do that regardless of the asset pipeline inclusion. We're still working on getting the rails 3.1 thing sorted so that's probably the best route.

@cmeiklejohn

This comment has been minimized.

Show comment Hide comment
@cmeiklejohn

cmeiklejohn Mar 14, 2012

Contributor

Regarding commented code: remove it, but do it in a separate pull request.

Contributor

cmeiklejohn commented Mar 14, 2012

Regarding commented code: remove it, but do it in a separate pull request.

@iain

This comment has been minimized.

Show comment Hide comment
@iain

iain Mar 14, 2012

Contributor

Ok, will do.

Contributor

iain commented Mar 14, 2012

Ok, will do.

Merge branch 'master' into keyboard-access
Conflicts:
	public/javascripts/application.js
@adkron

This comment has been minimized.

Show comment Hide comment
@adkron

adkron Nov 28, 2012

I think it would be better to fire the click event on the anchor so that future event hooks are still fired when using this methor or by clicking the link.

I think it would be better to fire the click event on the anchor so that future event hooks are still fired when using this methor or by clicking the link.

+ }
+
+ var visitSelectedGem = function() {
+ window.location = findSelectedGem().find("a").attr("href");

This comment has been minimized.

Show comment Hide comment
@adkron

adkron Nov 28, 2012

Contributor

This should be changed to fire the click event on the anchor tag. This would ensure that any events that are fired by clicking would also be fired by this method.

@adkron

adkron Nov 28, 2012

Contributor

This should be changed to fire the click event on the anchor tag. This would ensure that any events that are fired by clicking would also be fired by this method.

@qrush

This comment has been minimized.

Show comment Hide comment
@qrush

qrush Nov 28, 2014

Owner

We don't need this.

Owner

qrush commented Nov 28, 2014

We don't need this.

@qrush qrush closed this Nov 28, 2014

@qrush

This comment has been minimized.

Show comment Hide comment
@qrush

qrush Nov 28, 2014

Owner

Sorry if this sounds rude.

Rubygems.org isn't really a feed reader. If someone wants to build something like this with vim shortcuts on top of our API, then go for it. But on the site...we really don't need shortcuts and all in place.

Owner

qrush commented Nov 28, 2014

Sorry if this sounds rude.

Rubygems.org isn't really a feed reader. If someone wants to build something like this with vim shortcuts on top of our API, then go for it. But on the site...we really don't need shortcuts and all in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment