Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add J and K to navigate between listed gems #410

Closed
wants to merge 2 commits into from

Conversation

iain
Copy link
Contributor

@iain iain commented Mar 14, 2012

Just as Google Reader and many other apps, use J to move the selection down, K to move the selection up and press enter to go to the page of the gem.

I would've liked to write unit tests for this, but there is nothing setup for this. Maybe time to use the asset pipeline and throw in something like Jasmine/evergreen?

PS. There is a lot of commented out code in application.js. What should we do with this?

@cmeiklejohn
Copy link
Contributor

I like the jasmine idea, and you could do that regardless of the asset pipeline inclusion. We're still working on getting the rails 3.1 thing sorted so that's probably the best route.

@cmeiklejohn
Copy link
Contributor

Regarding commented code: remove it, but do it in a separate pull request.

@iain
Copy link
Contributor Author

iain commented Mar 14, 2012

Ok, will do.

Conflicts:
	public/javascripts/application.js
}

var visitSelectedGem = function() {
window.location = findSelectedGem().find("a").attr("href");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to fire the click event on the anchor tag. This would ensure that any events that are fired by clicking would also be fired by this method.

@qrush
Copy link
Member

qrush commented Nov 28, 2014

We don't need this.

@qrush qrush closed this Nov 28, 2014
@qrush
Copy link
Member

qrush commented Nov 28, 2014

Sorry if this sounds rude.

Rubygems.org isn't really a feed reader. If someone wants to build something like this with vim shortcuts on top of our API, then go for it. But on the site...we really don't need shortcuts and all in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants