Skip to content

Fix chart time labels #434

Merged
merged 2 commits into from Jun 24, 2012

2 participants

@stomar
stomar commented Jun 24, 2012

This pull request should fix the wrong date labels on the download charts of all gems, see issue #418. It should also reduce the chance of this bug being reintroduced with future changes of the days_ago default value.

Note that the code has only been tested separately and not in a running Rails app.

@sferik sferik commented on the diff Jun 24, 2012
app/helpers/chart_helper.rb
@@ -49,9 +49,9 @@ def downloads_over_time(versions, days_ago = 90)
counts << count
end
{
- :slug => version.slug,
- :counts => counts.reverse,
- :color => color_from_cycle(idx, versions.size)
+ :slug => version.slug,
+ :counts => counts.reverse,
+ :color => color_from_cycle(idx, versions.size)
@sferik
RubyGems member
sferik added a note Jun 24, 2012

Overall, this patch looks good. Did you change anything here or is this just stray whitespace?

@stomar
stomar added a note Jun 24, 2012

just trailing whitespace

@sferik
RubyGems member
sferik added a note Jun 24, 2012

Awesome! Thanks for cleaning this up. I hate trailing whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sferik sferik merged commit 28dd56f into rubygems:master Jun 24, 2012
@sferik
RubyGems member
sferik commented Jun 24, 2012

I just deployed this change to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.