Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Completes styling of sponsor list in the footer #448

Merged
merged 1 commit into from Nov 17, 2012

Conversation

Projects
None yet
6 participants
Contributor

tombryan commented Aug 14, 2012

This implements an extendable layout for sponsor links in the footer that will allow further sponsors to be added as required. A crossfade effect is being used on the StillAlive logo, and this can be added to the rest if logo files for each can be sourced in an appropriate format.

This pull request passes (merged 3be3c6a into 5e248dd).

Contributor

cmeiklejohn commented Sep 9, 2012

Attaching photo for those interested: http://cl.ly/image/2v2S1T3k0T3L.

I like it, @qrush, @evanphx you OK with this change?

mikel commented Nov 8, 2012

Hi there @qrush, just following up, you OK with this? Let's get er done :)

Contributor

adkron commented Nov 9, 2012

👍 I really like that it removes the clutter from the bottom menu. Adding the space is great. @qrush, @evanphx?

Contributor

adkron commented Nov 17, 2012

@cmeiklejohn, is silence golden? Should we merge this. It has been a few months.

Member

sferik commented Nov 17, 2012

Since this request is now over 3 months old and @qrush or @evanphx haven't chimed in yet, I'm going to merge it.

If those guys don't like it, they can revert it, but it's going in for now.

sferik added a commit that referenced this pull request Nov 17, 2012

Merge pull request #448 from reinteractive-open/feature/redesign_footer
Completes styling of sponsor list in the footer

@sferik sferik merged commit 6f2f0a2 into rubygems:master Nov 17, 2012

1 check passed

default The Travis build passed
Details

mikel commented Nov 18, 2012

Thank you @sferik !

mikel commented Nov 18, 2012

FWIW @qrush did mention in email to me that he liked the look of it.

sferik added a commit that referenced this pull request Jan 29, 2015

Merge pull request #448 from reinteractive-open/feature/redesign_footer
Completes styling of sponsor list in the footer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment