New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Rake task for updating gems' download counts #452
Conversation
Please, take a look at the issue #432 for why this is important. |
It looks like your latest changes broke the test suite -- can you investigate why? |
Well, I don't know why they broke – all I did was add a rake task. Maybe the tests were failing on master at the moment when I updated my commit. But that reminded me that I should really write tests for this rake task. I will report here when I've written them. |
Sweet, thank you. |
Looks like your failure is related to #438 and not your change. |
@janko-m Are you still working on this? |
Yes, I'm sorry for taking so long, I intend to finish this. |
I added the tests :) I'm wondering, do you get a notification when I amend a commit (like I did here)? Because I always put a comment after I amend just in case, and I'd rather not if you do get a notification :P |
FYI, I only receive notifications of comments, not of pushes. Thanks for working on this (and following-up). |
A Rake task for updating gems' download counts
My pleasure :) |
A Rake task for updating gems' download counts
I noticed that you don't have a task for that. I also noticed that rubygem records are updated very rarely with their number of downloads. Hopefully, now that you have this task, you can put it as a scheduled task to be run regularly (at least once a month, if it's possible).
I'm aware how big the
rubygems
table is, so I was careful about the memory. I've also written the task in a way that only 1 SQL query is executed for updating all rubygems.