Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Rake task for updating gems' download counts #452

Merged
merged 1 commit into from Nov 12, 2012
Merged

Conversation

@janko
Copy link
Contributor

@janko janko commented Aug 23, 2012

I noticed that you don't have a task for that. I also noticed that rubygem records are updated very rarely with their number of downloads. Hopefully, now that you have this task, you can put it as a scheduled task to be run regularly (at least once a month, if it's possible).

I'm aware how big the rubygems table is, so I was careful about the memory. I've also written the task in a way that only 1 SQL query is executed for updating all rubygems.

@janko
Copy link
Contributor Author

@janko janko commented Aug 23, 2012

Please, take a look at the issue #432 for why this is important.

@travisbot
Copy link

@travisbot travisbot commented Aug 23, 2012

This pull request passes (merged 0903014c into 29fabb2).

@travisbot
Copy link

@travisbot travisbot commented Aug 24, 2012

This pull request fails (merged 1d02d195 into 29fabb2).

@cmeiklejohn
Copy link
Contributor

@cmeiklejohn cmeiklejohn commented Sep 8, 2012

It looks like your latest changes broke the test suite -- can you investigate why?

@janko
Copy link
Contributor Author

@janko janko commented Sep 8, 2012

Well, I don't know why they broke – all I did was add a rake task. Maybe the tests were failing on master at the moment when I updated my commit.

But that reminded me that I should really write tests for this rake task. I will report here when I've written them.

@cmeiklejohn
Copy link
Contributor

@cmeiklejohn cmeiklejohn commented Sep 9, 2012

Sweet, thank you.

@cmeiklejohn
Copy link
Contributor

@cmeiklejohn cmeiklejohn commented Sep 9, 2012

Looks like your failure is related to #438 and not your change.

@adkron
Copy link
Contributor

@adkron adkron commented Nov 9, 2012

@janko-m Are you still working on this?

@janko
Copy link
Contributor Author

@janko janko commented Nov 9, 2012

Yes, I'm sorry for taking so long, I intend to finish this.

@janko
Copy link
Contributor Author

@janko janko commented Nov 12, 2012

I added the tests :)

I'm wondering, do you get a notification when I amend a commit (like I did here)? Because I always put a comment after I amend just in case, and I'd rather not if you do get a notification :P

@sferik
Copy link
Member

@sferik sferik commented Nov 12, 2012

FYI, I only receive notifications of comments, not of pushes. Thanks for working on this (and following-up).

sferik added a commit that referenced this pull request Nov 12, 2012
A Rake task for updating gems' download counts
@sferik sferik merged commit c93e65c into rubygems:master Nov 12, 2012
1 check passed
1 check passed
default The Travis build passed
Details
@janko
Copy link
Contributor Author

@janko janko commented Nov 12, 2012

My pleasure :)

@janko janko deleted the janko:downloads branch Sep 2, 2013
sferik added a commit that referenced this pull request Jan 29, 2015
A Rake task for updating gems' download counts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants