Added license information to versions. #458

merged 1 commit into from Nov 16, 2012


None yet

5 participants


The license is stored in the database upon creation of a new version. It is then made visible on the web and via the API. This addresses #363.

Existing gem versions will still need to have their license information backfilled, per #422.


Any thoughts on this? Would love to see this get merged.

@flavorjones flavorjones referenced this pull request in seattlerb/hoe Sep 15, 2012

Licenses #32


+1 on this -- closing #363 will most definitely help enterprisey Rubyists.

adkron commented Nov 6, 2012


It would be nice to see the license before I download it and find out I have to GPL my project.

@pivotal-gemini pivotal-gemini referenced this pull request in jqr/heroku_san Nov 8, 2012

Add license to gemspec #107


👍, I agree with @adkron.

@adkron adkron and 1 other commented on an outdated diff Nov 9, 2012
@@ -262,6 +264,10 @@ def join_authors
self.authors = self.authors.join(', ') if self.authors.is_a?(Array)
+ def join_licenses
+ self.licenses = self.licenses.join(', ') if self.licenses.is_a?(Array)
adkron Nov 9, 2012

Let's check that it responds to join instead of checking if it is an array. 🎉

@adkron adkron and 1 other commented on an outdated diff Nov 9, 2012
<h5><%= t '.owners_header' %></h5>
<p><%= links_to_owners(@rubygem) %></p>
<% end %>
+ <% if @latest_version.licenses.present? %>
adkron Nov 9, 2012

Instead of checking that licenses are present lets just print them. If they are empty then they are empty. What do you think?

adkron Nov 9, 2012

I've suggested this somewhere else, but what do you think about returning NA if their are no licenses?

moonmaster9000 Nov 9, 2012

Sounds great to me. On it.

Ian Lesperance & Matt Parker Display licenses for gem versions. b49db33

hi @adkron I've updated the commit. Cheers.

@adkron adkron merged commit b0f23a1 into rubygems:master Nov 16, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment